Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip button messed up on GitHub organization People tab #26174

Closed
ShivanKaul opened this issue Oct 21, 2022 · 1 comment · Fixed by brave/brave-site-specific-scripts#93
Closed

Comments

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Oct 21, 2022

Description

Similar to #18494, the Tip button is messed up on https://github.com/orgs/orgname/outside-collaborators.

We should just not have the Tip button on that People tab (I've mentioned the URLs below), it's a distraction from trying to do People management on a GitHub org. We currently don't have the Tip button on https://github.com/username/reponame/settings/access either.

Steps to Reproduce

Go to the Outside Collaborators page of a GitHub org: https://github.com/orgs/orgname/outside-collaborators

Actual result:

image

Expected result:

Not have Tip button on any of the following:

  1. https://github.com/orgs/*/people/*
  2. https://github.com/orgs/*/outside-collaborators
  3. https://github.com/orgs/*/pending_collaborators

Reproduces how often:

Always

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 20, 2023

Verification PASSED on

Brave | 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 10 Version 21H2 (Build 19044.2486)

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.699

image

Launched 1.44.177 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.699. Confirmed that there is no Tip icon in the following pages

Example Example
image image

[Confirmed with @ShivanKaul that the issue is fixed there is no Tip icon display in the GH page https://github.com/orgs/ietf-wg-ohai/outside-collaborators, unable to verify from my end as it's private repo]


Verification PASSED on

Brave | 1.47.171 Chromium: 109.0.5414.87 (Official Build) (arm64)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | macOS Version 12.5 (Build 21G72)

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.699

Screenshot 2023-01-20 at 6 40 58 PM

Launched 1.44.171 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.699. Confirmed that there is no Tip icon in the following pages

Example Example
Screenshot 2023-01-20 at 6 42 38 PM Screenshot 2023-01-20 at 6 44 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants