Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI bug on GitHub Organization page #18494

Closed
hubert-sikorski opened this issue Oct 1, 2021 · 8 comments
Closed

UI bug on GitHub Organization page #18494

hubert-sikorski opened this issue Oct 1, 2021 · 8 comments

Comments

@hubert-sikorski
Copy link

Description

Tip feature breaks UI on organization's member list

Steps to Reproduce

  1. Go to your organization page or create one
  2. Go to "People" section
  3. Take a look at members list

Actual result:

Screen Shot 2021-10-01 at 3 52 33 PM

Expected result:

Screen Shot 2021-10-01 at 3 52 41 PM

Reproduces how often:

All the time

Brave version (brave://version info)

Version 1.30.86 Chromium: 94.0.4606.61 (Official Build) (x86_64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? Yes, after disabling tips on GitHub
  • Is the issue reproducible on the latest version of Chrome? No
@hubert-sikorski
Copy link
Author

In an expected result, there should obviously be a tip button as well, one that does not break the whole thing haha

@srirambv
Copy link
Contributor

srirambv commented Oct 1, 2021

Possibly related to #18106

cc: @emerick

@hubert-sikorski
Copy link
Author

@srirambv I also use mac, but changing display settings for more space (as in #18106 thread) doesn't solve the issue unfortunately

@LaurenWags
Copy link
Member

cc @Miyayes @emerick

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 22, 2022

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.649

Reproduced the issue with the component 1.0.199
image

Launched 1.44.95 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.649, the Tip button is aligned correctly in https://github.com/orgs/brave/people and click on Send a tip button opens up the tipping banner

Example Example
image image

Spot checked following github pages and ensured inline tip is aligned correctly
https://github.com/brave/brave-browser/commits/master?after=05749476419ca759df8d5f7873bec79f58d2f624+69&branch=master&qualified_name=refs%2Fheads%2Fmaster
brave/brave-core#8852
#15005
https://github.com/emerick?tab=stars
https://gist.github.com/darkdh/85fed2542190510aaee0f3ad91091818

@stephendonner
Copy link

stephendonner commented Sep 22, 2022

Verified PASSED using

Brave 1.43.93 Chromium: 105.0.5195.127 (Official Build) (x86_64)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS macOS Version 11.7 (Build 20G817)

Reproduced the issue using component version 1.0.199:

Screen Shot 2022-09-22 at 9 02 13 AM

Launched 1.43.93 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.649, the Tip button is aligned correctly in https://github.com/orgs/brave/people and click on Tip button opens up the tipping banner

example example
Screen Shot 2022-09-22 at 9 03 03 AM Screen Shot 2022-09-22 at 9 03 11 AM

@mkarolin
Copy link
Contributor

@ShivanKaul
Copy link
Collaborator

There's a similar issue here: #26174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment