Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing on Google Slides doesn't work with Shields up #26079

Closed
Brave-Matt opened this issue Oct 17, 2022 · 9 comments
Closed

Printing on Google Slides doesn't work with Shields up #26079

Brave-Matt opened this issue Oct 17, 2022 · 9 comments
Assignees
Labels
fixed-by-webcompat-exception-manager Fixed by webcompat-exceptions.json list google OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include webcompat/fingerprinting webcompat breakage from shields fingerprinting protection webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/shields-down

Comments

@Brave-Matt
Copy link

Description

We had an old issue for Google services where Brave would force the user to save the [content] as a .pdf rather than initiating the print screen dialog:
#3694

This issue seems to have reappeared specifically for Google Slides. Attempting to print anything on Slides with Shields up forces the user to save the content as a .pdf. Attempting to print w/ Shields down displays the print screen dialog as intended:

Screen.Recording.2022-10-17.at.11.45.38.AM.mov

Steps to Reproduce

  1. Visit slides.google.com and open a presentation
  2. Attempt to print a slide w/Shields up
  3. Observe browser forces saving content as .pdf

Reproduces how often:

Always

Brave version (brave://version info)

v1.44.112

Version/Channel Information:

  • Can you reproduce this issue with the current release? Y
  • Can you reproduce this issue with the beta channel? Y
  • Can you reproduce this issue with the nightly channel? Y

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

User report:
https://community.brave.com/t/bug-missing-print-dialogue-in-google-slides-only-save-as-pdf/429045/14

@Brave-Matt Brave-Matt added webcompat/not-shields-related Sites are breaking because of something other than Shields. google OS/Desktop labels Oct 17, 2022
@rebron
Copy link
Collaborator

rebron commented Oct 17, 2022

cc: @ryanbr Looks like the print dialog show up ok with Shields down. Only an issue on Google Slides. Works fine (print dialog shows up) with Sheets and Docs with Shields down.

@twMat
Copy link

twMat commented Oct 20, 2022

@rebron - regarding the label "workaround/shields-down"; does this label mean it will not be properly fixed, i.e as there is a workaround?
Thx

@rebron
Copy link
Collaborator

rebron commented Oct 21, 2022

@twMat Only means that there is a workaround. We want a proper fix for it.

@rebron rebron added QA/Yes priority/P4 Planned work. We expect to get to it "soon". release-notes/include labels Oct 21, 2022
@ryanbr
Copy link

ryanbr commented Jan 16, 2023

Looks like a fingerprinting issue, Allowing fingerprinting on slides.google.com cc: @pilgrim-brave

@soliviantar
Copy link

Sorry, but I am having this problem now and shields down is not helping. I can confirm printing works normally on Sheets, but not on Slides.

@arthuredelstein arthuredelstein added the webcompat/fingerprinting webcompat breakage from shields fingerprinting protection label Feb 2, 2024
ryanbr added a commit to brave/adblock-lists that referenced this issue Jul 31, 2024
@ryanbr
Copy link

ryanbr commented Jul 31, 2024

"plugins" fingerprinting.

ryanbr added a commit to brave/adblock-lists that referenced this issue Jul 31, 2024
@ryanbr
Copy link

ryanbr commented Sep 9, 2024

Print preview now working

@ryanbr ryanbr closed this as completed Sep 9, 2024
@ryanbr ryanbr self-assigned this Sep 9, 2024
@ShivanKaul ShivanKaul added fixed-by-webcompat-exception-manager Fixed by webcompat-exceptions.json list and removed fixed-by-updating-brave labels Sep 9, 2024
@twMat
Copy link

twMat commented Sep 10, 2024

@ryanbr

Print preview now working

Well, still not for me. Turning shields off makes it work.
Latest official brave
Win 11

@ryanbr
Copy link

ryanbr commented Sep 10, 2024

Maybe check in a new profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-by-webcompat-exception-manager Fixed by webcompat-exceptions.json list google OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include webcompat/fingerprinting webcompat breakage from shields fingerprinting protection webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/shields-down
Projects
None yet
Development

No branches or pull requests

7 participants