Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new setting on brave://settings for IPFS gateway address for NFTs #25646

Closed
HEagle18 opened this issue Sep 27, 2022 · 1 comment · Fixed by brave/brave-core#15434
Closed
Assignees

Comments

@HEagle18
Copy link

HEagle18 commented Sep 27, 2022

Description

We currently have one IPFS setting for one public gateway address. We have been advised to add one for nft's specifically. See post here about how we should support https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1664291898140589

also note comment about trying a few times before failing.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added feature/web3/ipfs feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Sep 27, 2022
@HEagle18 HEagle18 added this to Web3 Sep 27, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Sep 30, 2022
@cypt4 cypt4 self-assigned this Oct 10, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Oct 16, 2022
Repository owner moved this from Backlog to Done in Web3 Oct 25, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 25, 2022
@srirambv
Copy link
Contributor

srirambv commented Nov 3, 2022

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Linux
  • Verified steps from brave/brave-core#15434
  • Verified a new setting IPFS public gateway address for NFT is available under brave://ipfs and has https://nftstorage.link is added by default
  • Verified able to update the NFT Gateway setting
  • Verified the gateway field can't be set to be blank
  • Verified tracing network with just wallet created, there is no entry for NFT gateway
  • Verified adding an NFT and viewing it starts showing NFT gateway in network trace
  • Verified able to still load IPFS pages via localnode or public gateway
  • Verified able to still load IPFS page resolved via ENS (L1/L2)
  • Verified able to still load an IPNS URI resolves using the public gateway/localnode
25646.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from brave/brave-core#15434
  • Verified a new setting IPFS public gateway address for NFT is available under brave://ipfs and has https://nftstorage.link is added by default
  • Verified able to update the NFT Gateway setting
  • Verified the gateway field can't be set to be blank
  • Verified tracing network with just wallet created, there is no entry for NFT gateway
  • Verified adding an NFT and viewing it starts showing NFT gateway in network trace
  • Verified able to still load IPFS pages via localnode or public gateway
  • Verified able to still load IPFS page resolved via ENS (L1/L2)
  • Verified able to still load an IPNS URI resolves using the public gateway/localnode
25646.mp4

Verification passed on

Brave 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (arm64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15434
  • Verified a new setting IPFS public gateway address for NFT is available under brave://ipfs and has https://nftstorage.link is added by default
  • Verified able to update the NFT Gateway setting
  • Verified the gateway field can't be set to be blank
  • Verified tracing network with just wallet created, there is no entry for NFT gateway
  • Verified adding an NFT and viewing it starts showing NFT gateway in network trace
  • Verified able to still load IPFS pages via localnode or public gateway
  • Verified able to still load IPFS page resolved via ENS (L1/L2)
  • Verified able to still load an IPNS URI resolves using the public gateway/localnode
25646.mp4

@rebron rebron changed the title add a new setting on brave://settings for IPFS gateway address for NFTs Add a new setting on brave://settings for IPFS gateway address for NFTs Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants