Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Solana account and make Solana the default network for new wallet installs #25432

Closed
yrliou opened this issue Sep 15, 2022 · 4 comments · Fixed by brave/brave-core#15125

Comments

@yrliou
Copy link
Member

yrliou commented Sep 15, 2022

For new wallet installs:

  • Have Solana account created
  • Have the globally default selected network be Solana

cc @bbondy

@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/solana feature/web3/wallet/core labels Sep 15, 2022
@yrliou yrliou added this to Web3 Sep 15, 2022
@yrliou yrliou moved this to In Progress in Web3 Sep 15, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Sep 19, 2022
Repository owner moved this from In Progress to Done in Web3 Sep 19, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 19, 2022
@cypt4 cypt4 added the OS/iOS Fixes related to iOS browser functionality label Sep 19, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Sep 19, 2022
@kjozwiak
Copy link
Member

The above requires 1.44.95 or higher for 1.44.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.44.97 x64 build

  • Verified steps from brave/brave-core#15125
  • Verified Solana network is set as active network for new wallet or restored wallet
  • Verified first Solana account generated for the seed is set as the active account for new wallet or restored wallet
  • Verified on upgrade from previous build, Solana isn't set as active network
  • Verified on upgrade from previous build with Solana account created doesn't make it the active account unless it was set as active before upgrade
  • Verified no crash when creating new wallet
  • Verified Solana account is selected after account creation
Create Account Restore Wallet
25432-New.Wallet.mp4
25432-Restore.Wallet.mp4

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Linux
  • Verified steps from brave/brave-core#15125
  • Verified Solana network is set as active network for new wallet or restored wallet
  • Verified first Solana account generated for the seed is set as the active account for new wallet or restored wallet
  • Verified on upgrade from previous build, Solana isn't set as active network
  • Verified on upgrade from previous build with Solana account created doesn't make it the active account unless it was set as active before upgrade
25432.mp4

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#15125
  • Verified Solana network is set as active network for new wallet or restored wallet
  • Verified first Solana account generated for the seed is set as the active account for new wallet or restored wallet
  • Verified on upgrade from previous build, Solana isn't set as active network
  • Verified on upgrade from previous build with Solana account created doesn't make it the active account unless it was set as active before upgrade
25432.mp4

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (arm64)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#15125
  • Verified Solana network is set as active network for new wallet or restored wallet
  • Verified first Solana account generated for the seed is set as the active account for new wallet or restored wallet
  • Verified on upgrade from previous build, Solana isn't set as active network
  • Verified on upgrade from previous build with Solana account created doesn't make it the active account unless it was set as active before upgrade
25432-macOS.mov

@urbenlegend
Copy link

Is there anyway I can delete this newly created Solana account? I don't plan on using it and it's just an eyesore when I view my accounts list.

Honestly, I think users should be given a choice of which account to create during wallet creation so that they aren't stuck with accounts that they didn't want in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants