Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Disallow Rewards from being enabled and show clearer unavailable messaging for users in unavailable list countries #25276

Closed
1 of 2 tasks
Miyayes opened this issue Sep 8, 2022 · 3 comments · Fixed by brave/brave-core#16592
Closed
1 of 2 tasks

[Android] Disallow Rewards from being enabled and show clearer unavailable messaging for users in unavailable list countries #25276

Miyayes opened this issue Sep 8, 2022 · 3 comments · Fixed by brave/brave-core#16592
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality policy This is a policy choice, relates to terms & conditions, or has a legal element to it. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 8, 2022 •
edited
Loading

Description

Android equivalent of #25275.

Designs: https://www.figma.com/file/ag8i1OV5vpvn4SiOhW2c0f/Github-fixes?node-id=1853%3A34996

  • Hide BAT icon for Rewards panel if device region is in unavailable list
  • Show messaging on Rewards settings page (inherited from desktop)

Learn more link goes to: https://support.brave.com/hc/en-us/articles/9053832354957
@Miyayes Miyayes added feature/rewards QA/Yes release-notes/include policy This is a policy choice, relates to terms & conditions, or has a legal element to it. OS/Android Fixes related to Android browser functionality labels Sep 8, 2022
@Miyayes Miyayes added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Sep 8, 2022
@Miyayes Miyayes removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Sep 9, 2022
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 14, 2022
@deeppandya deeppandya mentioned this issue Jan 10, 2023
Merged
25 tasks
@Miyayes Miyayes changed the title [Android] Disallow Rewards from being enabled and show clearer unavailable messaging for users in OFAC list countries [Android] Disallow Rewards from being enabled and show clearer unavailable messaging for users in unavailable list countries Jan 11, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 12, 2023
@kjozwiak kjozwiak added Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected and removed Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Feb 10, 2023
@kjozwiak
Copy link
Member

@LaurenWags any thoughts on the above? @Uni-verse and myself are in the triage call and debating if this needs to be labelled as QA/Test-All-Device-Types. Looks like Desktop was only done on Win x64 so we're assuming one device is fine but let is know if you feel differently.

@LaurenWags
Copy link
Member

Agree, I think just one is fine 👍🏻

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Mar 6, 2023
Closed
@GeetaSarvadnya
Copy link

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.49.118

This was referenced Mar 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality policy This is a policy choice, relates to terms & conditions, or has a legal element to it. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

OFAC UI changes for rewards brave/brave-core
8 participants
@kjozwiak @deeppandya @Miyayes @LaurenWags @sujitacharya2005 @GeetaSarvadnya @brave-builds @minkyeongshin