Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Rewards from being enabled and show clearer unavailable messaging for users in unavailable list countries #25275

Closed
5 tasks
Miyayes opened this issue Sep 8, 2022 · 5 comments · Fixed by brave/brave-core#15446
Assignees
Labels
feature/rewards OS/Desktop policy This is a policy choice, relates to terms & conditions, or has a legal element to it. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 8, 2022

Description

If OS locale country ∈ unavailable list, then:

  • Show Rewards unavailable messaging in brave://rewards settings page
  • Hide the Rewards NTP widget
  • Disable in-line tipping buttons
  • Hide BAT icon in the URL bar
  • Hide NTPSI-related toggles

For existing users, pause any Rewards services while current OS region country ∈ unavailable list.

Designs: https://www.figma.com/file/ag8i1OV5vpvn4SiOhW2c0f/Github-fixes?node-id=1853%3A34996

Learn more link goes to: https://support.brave.com/hc/en-us/articles/9053832354957

@Miyayes Miyayes added feature/rewards design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. policy This is a policy choice, relates to terms & conditions, or has a legal element to it. OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 8, 2022
@Miyayes Miyayes added QA/Yes release-notes/include and removed OS/Android Fixes related to Android browser functionality labels Sep 8, 2022
@Miyayes Miyayes removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Sep 9, 2022
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 14, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Sep 19, 2022

cc: @tmancey for the common shared code where this list will live.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Oct 6, 2022

Unavailable list will come from: #25633

@LaurenWags
Copy link
Member

@Miyayes @mkarolin

Looks like a test plan is needed, labelling as QA/Blocked until this is sorted.

cc @kjozwiak @rebron

@LaurenWags
Copy link
Member

LaurenWags commented Dec 8, 2022

Per discussion with @Miyayes test plan is under https://github.com/brave/internal/issues/981, verification notes should be added there as well.

cc @brave/qa-team

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 3, 2023
@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 4, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
-- | --
Revision | 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS | Windows 10 Version 21H2 (Build 19044.2364)

Verification notes can be viewed under https://github.com/brave/internal/issues/981#issuecomment-1369867279.

@Miyayes Miyayes changed the title Disallow Rewards from being enabled and show clearer unavailable messaging for users in OFAC list countries Disallow Rewards from being enabled and show clearer unavailable messaging for users in unavailable list countries Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Desktop policy This is a policy choice, relates to terms & conditions, or has a legal element to it. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants