Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tokens, enable fantom #25029

Closed
muliswilliam opened this issue Aug 29, 2022 · 2 comments · Fixed by brave/brave-core#14881
Closed

Add missing tokens, enable fantom #25029

muliswilliam opened this issue Aug 29, 2022 · 2 comments · Fixed by brave/brave-core#14881
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented Aug 29, 2022 •
edited
Loading

Add the the following tokens:

  1. 0x
  2. Axie Infinity
  3. MATIC (on ethereum chain)
  4. TUSD
@muliswilliam muliswilliam self-assigned this Aug 29, 2022
@muliswilliam muliswilliam moved this from Backlog to In Progress in Web3 Aug 29, 2022
@muliswilliam muliswilliam mentioned this issue Aug 30, 2022
Merged
25 tasks
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 Aug 30, 2022
@muliswilliam muliswilliam changed the title Add missing tokens, enable fantom and use update logo for Sardine on-ramp provider Add missing tokens, enable fantom Aug 30, 2022
Repository owner moved this from In Review to Done in Web3 Aug 31, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 31, 2022
@brave-builds brave-builds mentioned this issue Sep 2, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2022

The above requires 1.44.78 or higher for 1.44.x verification 👍

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 7, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (64-bit)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS Linux
  • Verified steps from brave/brave-core#14881
  • Verified missing tokens are now listed
  • Verified Buy via Sardine option is shown for supported tokens
  • Verified on both light and dark theme
  • Verified Sardine is only shown for US locale
  • Encountered #25422
25209-Linux.mp4

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (64-bit)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from brave/brave-core#14881
  • Verified missing tokens are now listed
  • Verified Buy via Sardine option is shown for supported tokens
  • Verified on both light and dark theme
  • Verified Sardine is only shown for US locale
  • Encountered #25422
25209-Windows.mp4

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (arm64)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#14881
  • Verified missing tokens are now listed
  • Verified Buy via Sardine option is shown for supported tokens
  • Verified on both light and dark theme
  • Verified Sardine is only shown for US locale
  • Encountered #25422
25029-macOS.mov

@srirambv srirambv mentioned this issue Sep 15, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Add missing tokens and update sardine logo brave/brave-core
5 participants
@kjozwiak @srirambv @LaurenWags @brave-builds @muliswilliam