Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add updated logo for Sardine #24899

Closed
HEagle18 opened this issue Aug 23, 2022 · 3 comments · Fixed by brave/brave-core#14881
Closed

Add updated logo for Sardine #24899

HEagle18 opened this issue Aug 23, 2022 · 3 comments · Fixed by brave/brave-core#14881
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.44.x - Release

Comments

@HEagle18
Copy link

Description

See https://bravesoftware.slack.com/archives/C03FP409W2X/p1660571165447769 for details

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@HEagle18 HEagle18 added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Aug 23, 2022
@HEagle18 HEagle18 added this to Web3 Aug 23, 2022
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Aug 23, 2022
@HEagle18 HEagle18 moved this to Backlog in Web3 Aug 26, 2022
@muliswilliam muliswilliam moved this from Backlog to In Progress in Web3 Aug 30, 2022
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 Aug 30, 2022
@muliswilliam muliswilliam mentioned this issue Aug 30, 2022
Merged
25 tasks
@srirambv
Copy link
Contributor

srirambv commented Sep 2, 2022

Fixed by brave/brave-core#14881

@srirambv srirambv closed this as completed Sep 2, 2022
Repository owner moved this from In Review to Done in Web3 Sep 2, 2022
@srirambv srirambv added this to the 1.45.x - Nightly milestone Sep 2, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2022

The above requires 1.44.78 or higher for 1.44.x verification 👍

@kjozwiak kjozwiak mentioned this issue Sep 7, 2022
Merged
7 tasks
@srirambv
Copy link
Contributor

Verified as part of #25029 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Add missing tokens and update sardine logo brave/brave-core
5 participants
@kjozwiak @HEagle18 @srirambv @brave-builds @muliswilliam