Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid urls in ad catalog #2472

Closed
bridiver opened this issue Dec 11, 2018 · 0 comments · Fixed by brave/brave-core#1067
Closed

invalid urls in ad catalog #2472

bridiver opened this issue Dec 11, 2018 · 0 comments · Fixed by brave/brave-core#1067
Assignees
@bridiver
Labels
feature/rewards QA/No release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@bridiver
Copy link
Contributor

Some urls in the ad catalog don't contain http/https so they fail GURL validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
feature/rewards QA/No release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

guard against invalid urls from bat-native-ads notifications brave/brave-core
3 participants
@bridiver @bbondy @NejcZdovc