Always show Dylan Malval's image as a first background image after launch

[simonhong]

Description

Set Dylan Malval's image as a first background image after launch

Steps to Reproduce

1. Launch Brave and make sure there is no opened NTP
2. Open first NTP
3. Check its background image is Dylan Malval's image

Actual result:

Expected result:

[simonhong]

Verified with dev component with --dev-go-updater-url.

[simonhong]

Fixed with NTP Background Images - Version: 1.0.7

[simonhong]

I set this milestone to currently available release milestone (1.42.x - Release #3) as background images component update is applied to all channels. cc @rebron @kjozwiak

[kjozwiak]

@simonhong quickly went through the above and noticed the following two things:

Case #1 - NTP SI being opened second rather than 4th

From what I remember, NTP SI should always be opened on the 4th tab. I don't exactly remember if the second tab should always be a NTP SI when launching a new profile. If that's the case, then this isn't an issue/problem 👍

Welcome.to.Brave.-.Brave.2022-08-11.23-14-19.mp4

Case #2 - Opening several NTP quickly right after launch will use the same tab

When you open a few NTP right away once the browser launches, it opens the same tab several times. However, I think it's probably related due to the images still not being pulled/downloaded via the component, hence using the image from Dylan Malval as the default until the new images are downloaded/ready to use. So pretty sure this isn't any issue.

Welcome.to.Brave.-.Brave.2022-08-11.23-17-53.mp4

@simonhong I guess we just need calcification in the first case. Second case is expected behaviour 👍

[simonhong]

@kjozwiak Thanks for checking! I think above both cases are all expected behavior.
For case 1, second NTP can show NTP SI with fresh profile.
For case 2, it's possible if background images component is not ready.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.42.95 Chromium: 104.0.5112.81 (Official Build) (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 10 Version 21H2 (Build 19044.1889)

• Verified the STR from the decsription and ensured Dylan Malval's is displayed as the first backgroung image when 1st NTP is opened after the browser launch
• If I wait for enough time (until component load) the order of NTP ST is shown in the order (2th NTP, 4 NTP, 8NTP etc...)
• Encounter the case 2 from Always show Dylan Malval's image as a first background image after launch #24583 (comment) which is expected as per Always show Dylan Malval's image as a first background image after launch #24583 (comment)

[btlechowski]

Verification passed on

Brave	1.42.95 Chromium: 104.0.5112.81 (Official Build) (64-bit)
Revision	5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS	Ubuntu 18.04 LTS

Verified the Dylan Malval image is default after launch

Verified NTPSI is shown on 2nd 6th 10th etc NTP

---

Verified using

Brave | 1.42.95 Chromium: 104.0.5112.81 (Official Build) (x86_64)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | macOS Version 12.5 (Build 21G72)

Verified the Dylan Malval image is default after launch: