Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset option under Language to translate into popup isn't functioning when #brave-translate-go is enabled #24266

Open
GeetaSarvadnya opened this issue Jul 26, 2022 · 2 comments
Assignees
Labels
bug OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 26, 2022

Description

Reset option under Language to translate into popup isn't functioning when #brave-translate-go is enabled

Steps to Reproduce

  1. Clean profile 1.43.43
  2. Enable the flag #brave-translate-go via brave://flags
  3. Open a non english site https://www.deutschland.de/de
  4. Click on the translate bubble in the URL bar
  5. Click on Translate options 3 dot menu
  6. Choose another langauge from the list of options
  7. Select another language (e.g Hindi ) and ensured that page gets translated to selected language
  8. Reset option is disabled, select another language and click on Reset nothing happens

Actual result:

Reset option under Language to translate into popup isn't functioning

Translate

Expected result:

Reset option under Language to translate into popup should reset the traslated langauge to original language

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.43.43 Chromium: 104.0.5112.57 (Official Build) nightly (64-bit)
Revision 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @rebron @mkarolin @brave/legacy_qa

@kjozwiak
Copy link
Member

@GeetaSarvadnya just a quick FYI, with Nightly, we've enabled Brave Translate via Griffin so there's no need to enable #brave-translate-go using brave://flags. It will automatically enable once you restart the browser and pull the studies from Griffin 👍 Change was done via brave/brave-variations#313.

Can double check and see if you're part of the study on Nightly by checking brave://version and seeing you have BraveTranslateStudy:Enabled listed via Active variations.

@rebron
Copy link
Collaborator

rebron commented Jul 26, 2022

@GeetaSarvadnya Can you post what you have in brave://settings/languages
Screenshot 2022-07-26 at 2 06 00 PM

I think this is working correctly and Reset is resetting your language preference for that dialog which I think is Hindi. I don't think Reset means to change the page back to the original language page.

Can you go to another site, choose a different language like French, and hit Reset again. Should then reset to Hindi again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
Status: On Deck
Development

No branches or pull requests

3 participants