Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 104.0.5112.57 to Chromium 104.0.5112.69 #24291

Closed
mkarolin opened this issue Jul 27, 2022 · 8 comments · Fixed by brave/brave-core#14362
Closed

Upgrade from Chromium 104.0.5112.57 to Chromium 104.0.5112.69 #24291

mkarolin opened this issue Jul 27, 2022 · 8 comments · Fixed by brave/brave-core#14362

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jul 27, 2022

Minor Chromium bump.

Chromium Desktop bump to 104.0.5112.65
Chromium Android bump to 104.0.5112.69

https://chromium.googlesource.com/chromium/src/+log/104.0.5112.57..104.0.5112.69?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@kjozwiak
Copy link
Member

The above requires 1.42.81 or higher for 1.42.x verification 👍

@kjozwiak
Copy link
Member

Both macOS & Linux will still need to run through the affected area's mentioned via #23092 (comment). Both Win & Android are completed as per #23092 (comment) & #23092 (comment).

@LaurenWags if we end up running out of time, we can always skip Linux but should at least do a check on macOS.

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit)
-- | --
Revision | 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS | Windows 10 Version 21H2 (Build 19044.1826)

image

@btlechowski
Copy link

Verification passed on

Brave 1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Ubuntu 18.04 LTS
History page has correct style_PASSED
  • Confirmed that history page has the correct style and controls on the history page works as expected
  • Confirmed browser history is shown as expected on brave://history page

image

Translate bubble_PASSED

Disable - #brave-translate-go

  • Confirmed translate bubble is shown when non english site is visited
  • Confirmed translate extension can be installed without any issues
  • Confirmed that non english site can be translated in intended language

image
image
image
image
image

Enable - #brave-translate-go

  • Confirmed translate bubble is shown when non english site is visited
  • Confirmed that click on Translate options shows the list of options listed below:
    1. Choose another language
    2. Always translate Polish
    3. Never translate Polish
    4. Never trsalate this site
    5. Page is not in Polish
  • Confirmed that Choose another language options opens up the list of languages
  • Confirmed that another language can be selected from Choose another language options and page gets translated in selected language successfully
  • Reset option under Language to translate into popup isn't functioning, logged Reset option under Language to translate into popup isn't functioning when #brave-translate-go is enabled #24266

image
image

Hardware concurrency farbling works as expected_PASSED

Disucussed with @mkarolin, verified the issue #10808

  • open any site
  • open dev tool->console
  • enter window.navigator.hardwareConcurrency in console
  • verify the value for both Block fingerprinting and Aggressively block fingerprinting in the shields.

[Note: the value should be between 2 and your actual processors count]

Default/Block fingerprinting

image

Aggressively block fingerprinting

image

DeAmp and Speedreader work as expected_PASSED
DeAmp_PASSED

(Refer the issue - #22228, discussed with @mkarolin )

de-AMP Disabled

  • ensured that Auto-redirect AMP pages was disabled via brave://settings/shields
  • Loaded https://www.google.com and then searched for Top Stories
  • inspected the first article via DevTools and ensured that jsaction attribute appeared in the anchor link
  • clicked on the link and ensured that the AMP version of the website/news article was being loaded
  • validated with google.com as well and results were same as expected

image
image

de-AMP Enabled

  • ensured that Auto-redirect AMP pages was enabled via brave://settings/shields
  • loaded https://www.google.com and then searched for Top Stories
  • inspected the first article via DevTools and ensured that jsaction attribute didn't appear in the anchor link
  • clicked on the link and ensured that the de-AMP version of the website/news article was being loaded
  • validated with google.com as well and results were same as expected
Speedreader_PASSED
  • Confirmed that able to enable/disable the Speedreader feature correctly from the speedreader icon via URL bar
  • Disable the global speedreader settings from brave://settings/appearance and open a article https://metro.co.uk/news/ click on the reader mode icon and ensured article goes into the reader mode, click again on the reader mode icon exit the reader mode as expected
  • Enable the global speedreader settings via brave://settings/appearance and open an article and ensured article is opened in reader mode.

image
image

Settings UI and style works/looks correctly_PASSED
  • Confirmed that settings UI looks good and click on each settings redirected to the intended pages
  • Confirmed that no new brave://settings are added as part of CR104
  • Confirmed that no new brave://settings/content settings are added as part of CR104
  • Confirmed that there is a new settings added in brave://settings/system as part of Brave

brave://settings/system

image


Settings comparison

  • Confirmed that no new brave://settings are added as part of CR104
  • Confirmed that no new brave://settings/content settings are added as part of CR104
  • Confirmed that there is a new settings added in brave://settings/system as part of Brave

Components updater

  • No new componnets are added as part of CR104
  • Components are updates successfully without any error

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 29, 2022

Verified on Samsung GS 21 using

Brave	1.42.83 Chromium: 104.0.5112.69 (Official Build) (64-bit) 
Revision	7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS	Android 12; Build/SP1A.210812.016

Affected Areas: #23092 (comment)

  • Clean profile
  • Upgrade from 1.42.80

0

@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 29, 2022

Verified on Samsung Tab S7 using

Brave	1.42.82 Chromium: 104.0.5112.69 (Official Build) (64-bit) 
Revision	7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS	Android 12; Build/SP1A.210812.016

Affected Areas: #23092 (comment)

  • Clean profile
  • Upgrade from 1.42.80

screenshot-1659124759801

@stephendonner
Copy link

stephendonner commented Jul 29, 2022

Verification PASSED using

Brave 1.42.82 Chromium: 104.0.5112.69 (Official Build) (x86_64)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS macOS Version 13.0 (Build 22A5311f)
History page has correct style - PASSED
  • confirmed that the history page has the correct style and controls on the history page works as expected
  • confirmed browser history is shown as expected on brave://history page
Screenshot 2022-07-29 at 2 50 34 PM
Translate bubble - PASSED

Disable - #brave-translate-go

  • confirmed translate bubble is shown when non-English site is visited
  • confirmed that non-English site can be translated in intended language
example example example example example
Screenshot 2022-07-29 at 2 56 21 PM Screen Shot 2022-08-01 at 11 56 27 AM Screen Shot 2022-08-01 at 11 56 37 AM Screen Shot 2022-08-01 at 11 56 51 AM Screen Shot 2022-08-01 at 11 57 05 AM

Enable - #brave-translate-go

  • confirmed translate bubble is shown when non-English site is visited
  • confirmed that clicking on Translate options shows the list of options listed below:
    1. Choose another language
    2. Always translate Spanish
    3. Never translate Spanish
    4. Never translate this site
    5. Page is not in Spanish
  • confirmed that Choose another language options opens up the list of languages
  • confirmed that another language can be selected from Choose another language options and page gets translated into selected language successfully
example example example example example
Screenshot 2022-07-29 at 3 03 21 PM Screenshot 2022-07-29 at 3 03 41 PM Screenshot 2022-07-29 at 3 04 31 PM Screenshot 2022-07-29 at 3 04 53 PM Screenshot 2022-07-29 at 3 04 57 PM
Hardware concurrency "farbling" works as expected - PASSED
  • open any site
  • open Developer Tools-> Console
  • enter window.navigator.hardwareConcurrency in console
  • verify the value for both Block fingerprinting and Aggressively block fingerprinting in the shields.

[Note: the value should be between 2 and your actual processors count]

Default/Block fingerprinting

Screenshot 2022-07-29 at 3 12 20 PM

Aggressively block fingerprinting

Screenshot 2022-07-29 at 3 12 55 PM
De-AMP and Speedreader work as expected - PASSED
De-AMP - PASSED

(Refer to the issue - #22228, discussed with @mkarolin)

de-AMP Enabled (default) - PASSED

  • ensured that Auto-redirect AMP pages was enabled via brave://settings/shields, by default
  • loaded https://www.google.com and then searched for Top Stories
  • inspected the first article via DevTools and ensured that jsaction attribute didn't appear in the anchor link
  • clicked on the link and ensured that the de-AMP version of the website/news article was being loaded
  • validated with google.com as well and results were same as expected
de-AMP enabled jsaction=
Screen Shot 2022-07-30 at 10 36 36 AM Screen Shot 2022-07-30 at 10 36 41 AM

de-AMP Disabled - PASSED

  • ensured that Auto-redirect AMP pages was disabled via brave://settings/shields
  • loaded https://www.google.com and then searched for Top Stories
  • inspected the first article via DevTools and ensured that jsaction attribute appeared in the anchor link
  • clicked on the link and ensured that the AMP version of the website/news article was being loaded
  • validated with google.com as well and results were same as expected
de-AMP disabled no jsaction=
Screen Shot 2022-07-30 at 10 36 55 AM Screen Shot 2022-07-30 at 10 50 32 AM
Speedreader - PASSED
  • confirmed was able to enable/disable the Speedreader feature correctly from the Speedreader icon via URL bar
  • disable the global Speedreader settings from brave://settings/appearance and opened a article https://metro.co.uk/news/
  • clicked on the reader mode icon and ensured article went into reader mode
  • clicked again on the reader mode icon, which exited the reader mode as expected
  • enabled the global Speedreader settings via brave://settings/appearance and opened an article and ensured article was opened in reader mode.
example example
Screenshot 2022-07-29 at 3 31 30 PM Screenshot 2022-07-29 at 3 31 34 PM
Settings UI and style works/looks correctly - PASSED
  • Confirmed that settings UI looks good and click on each settings redirected to the intended pages
  • Confirmed that no new brave://settings are added as part of CR104
  • Confirmed that no new brave://settings/content settings are added as part of CR104
  • Confirmed that there is a new settings added in brave://settings/system as part of Brave

brave://settings/system

Settings comparison - PASSED
  • Confirmed that no new brave://settings are added as part of CR104
  • Confirmed that no new brave://settings/content settings are added as part of CR104
  • Confirmed that there are no new settings added in brave://settings/system
Components updater - PASSED
  • No new components are added as part of CR104
  • Components are updated successfully without any error (brave://components) (~8 mins)
Screenshot 2022-07-29 at 9 49 24 PM
Brave startup calls - PASSED
  • Confirmed that only Brave domains are listed in Charles Proxy, when the build is launched with a clean profile
  • Confirmed no calls to Google.com, gstatic.*, etc domains when the build is launched with a clean profile
Screenshot 2022-07-29 at 10 01 45 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 29, 2022
@LaurenWags
Copy link
Member

Removing release-notes/include as this is superseded by #24364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment