-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 104.0.5112.57 to Chromium 104.0.5112.69 #24291
Comments
The above requires |
Both @LaurenWags if we end up running out of time, we can always skip |
Verification passed on
History page has correct style_PASSED
Translate bubble_PASSEDDisable - #brave-translate-go
Enable - #brave-translate-go
Hardware concurrency farbling works as expected_PASSEDDisucussed with @mkarolin, verified the issue #10808
[Note: the value should be between 2 and your actual processors count] Default/Block fingerprinting Aggressively block fingerprinting DeAmp and Speedreader work as expected_PASSEDDeAmp_PASSED(Refer the issue - #22228, discussed with @mkarolin )
Speedreader_PASSED
Settings UI and style works/looks correctly_PASSED
brave://settings/system Settings comparison
Components updater
Brave startup calls
|
Verified on
Affected Areas: #23092 (comment)
|
Verified on
Affected Areas: #23092 (comment)
|
Verification
|
Brave | 1.42.82 Chromium: 104.0.5112.69 (Official Build) (x86_64) |
---|---|
Revision | 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213} |
OS | macOS Version 13.0 (Build 22A5311f) |
- Verified the test plan from Upgrade from Chromium 103 to Chromium 104. #23092 (comment)
History page has correct style - PASSED
- confirmed that the history page has the correct style and controls on the history page works as expected
- confirmed browser history is shown as expected on
brave://history
page
Translate bubble - PASSED
Disable - #brave-translate-go
- confirmed translate bubble is shown when non-English site is visited
- confirmed that non-English site can be translated in intended language
example | example | example | example | example |
---|---|---|---|---|
Enable - #brave-translate-go
- confirmed translate bubble is shown when non-English site is visited
- confirmed that clicking on
Translate options
shows the list of options listed below:
1.Choose another language
2.Always translate Spanish
3.Never translate Spanish
4.Never translate this site
5.Page is not in Spanish
- confirmed that
Choose another language
options opens up the list of languages - confirmed that another language can be selected from
Choose another language
options and page gets translated into selected language successfully
example | example | example | example | example |
---|---|---|---|---|
Hardware concurrency "farbling" works as expected - PASSED
- open any site
- open
Developer Tools
->Console
- enter
window.navigator.hardwareConcurrency
in console - verify the value for both
Block fingerprinting
andAggressively block fingerprinting
in the shields.
[Note: the value should be between 2 and your actual processors count]
Default/Block fingerprinting
Aggressively block fingerprinting
De-AMP and Speedreader work as expected - PASSED
De-AMP - PASSED
(Refer to the issue - #22228, discussed with @mkarolin)
de-AMP Enabled
(default) - PASSED
- ensured that
Auto-redirect AMP pages
was enabled viabrave://settings/shields
, by default - loaded
https://www.google.com
and then searched forTop Stories
- inspected the first article via DevTools and ensured that
jsaction
attribute didn't appear in the anchor link - clicked on the link and ensured that the de-AMP version of the website/news article was being loaded
- validated with
google.com
as well and results were same as expected
de-AMP enabled |
jsaction= |
---|---|
de-AMP Disabled
- PASSED
- ensured that
Auto-redirect AMP pages
was disabled viabrave://settings/shields
- loaded
https://www.google.com
and then searched forTop Stories
- inspected the first article via DevTools and ensured that
jsaction
attribute appeared in the anchor link - clicked on the link and ensured that the AMP version of the website/news article was being loaded
- validated with
google.com
as well and results were same as expected
de-AMP disabled |
no jsaction= |
---|---|
Speedreader - PASSED
- confirmed was able to enable/disable the Speedreader feature correctly from the Speedreader icon via URL bar
- disable the global Speedreader settings from
brave://settings/appearance
and opened a articlehttps://metro.co.uk/news/
- clicked on the
reader mode
icon and ensured article went into reader mode - clicked again on the
reader mode
icon, which exited the reader mode as expected - enabled the global Speedreader settings via
brave://settings/appearance
and opened an article and ensured article was opened in reader mode.
example | example |
---|---|
Settings UI and style works/looks correctly - PASSED
- Confirmed that settings UI looks good and click on each settings redirected to the intended pages
- Confirmed that no new
brave://settings
are added as part of CR104 - Confirmed that no new
brave://settings/content
settings are added as part of CR104 - Confirmed that there is a new settings added in
brave://settings/system
as part of Brave
brave://settings/system
Settings comparison - PASSED
- Confirmed that no new
brave://settings
are added as part of CR104 - Confirmed that no new
brave://settings/content
settings are added as part of CR104 - Confirmed that there are no new settings added in
brave://settings/system
Removing |
Minor Chromium bump.
Chromium Desktop bump to 104.0.5112.65
Chromium Android bump to 104.0.5112.69
https://chromium.googlesource.com/chromium/src/+log/104.0.5112.57..104.0.5112.69?pretty=fuller&n=10000
QA tests:
Check branding items
Check for version bump
Additional checks:
No specific code changes in Brave (only line number changes in patches).
The text was updated successfully, but these errors were encountered: