Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] another IPFS crash bypass #24211

Closed
diracdeltas opened this issue Jul 22, 2022 · 3 comments · Fixed by brave/brave-core#14313
Closed

[hackerone] another IPFS crash bypass #24211

diracdeltas opened this issue Jul 22, 2022 · 3 comments · Fixed by brave/brave-core#14313
Assignees
@cypt4
Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include security
Milestone
1.43.x - Release

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jul 22, 2022 •
edited
Loading

https://hackerone.com/reports/1646204

credit: neeythann
cypt4 added a commit to brave/brave-core that referenced this issue Jul 23, 2022
@cypt4
Always create new origin for ipfs\ipns requests
db84f07 
Resolves brave/brave-browser#24211
cypt4 added a commit to brave/brave-core that referenced this issue Jul 25, 2022
@cypt4
Do not commit subframe navigations for ipfs
be17a4d 
Fixes brave/brave-browser#24211
@cypt4 cypt4 mentioned this issue Jul 25, 2022
Merged
25 tasks
@cypt4 cypt4 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes feature/web3/ipfs labels Jul 25, 2022
cypt4 added a commit to brave/brave-core that referenced this issue Aug 2, 2022
@cypt4
Do not commit subframe navigations for ipfs
7330454 
Fixes brave/brave-browser#24211
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 3, 2022
@stephendonner stephendonner mentioned this issue Aug 4, 2022
Closed
@brave-builds brave-builds mentioned this issue Aug 5, 2022
Merged
7 tasks
@cypt4 cypt4 modified the milestones: 1.44.x - Nightly, 1.43.x - Beta Aug 5, 2022
@cypt4 cypt4 added this to the 1.43.x - Beta milestone Aug 5, 2022
@LaurenWags
Copy link
Member

Added QA/Blocked label as this is waiting on an uplift before it can be tested in 1.43.x.

@LaurenWags
Copy link
Member

PR has been uplifted, this requires 1.43.62 or above to test

@stephendonner
Copy link

Verified PASSED using

Brave 1.43.62 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Pre-requisite:

  • created a minimal testcase based on the HackerOne report
  • started a Python HTTP server via: python3 -m http.server 8080

Steps:

  1. installed 1.43.62
  2. launched Brave
  3. opened a new Private window
  4. opened a new Private window w/Tor
  5. opened a new Guest window
  6. loaded the minimal testcase via localhost:8080 in the above window types
Private window Private window w/Tor Guest window
Screen Shot 2022-08-08 at 6 18 07 PM Screen Shot 2022-08-08 at 6 10 13 PM Screen Shot 2022-08-08 at 6 09 58 PM

@LaurenWags LaurenWags mentioned this issue Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include security
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Do not commit subframe navigations for ipfs brave/brave-core
5 participants
@stephendonner @diracdeltas @LaurenWags @brave-builds @cypt4