-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit top site dialog displays in the background instead of the foreground #23685
Comments
cc: @fallaciousreasoning We have a regression where the dialog to edit sites is displaying in the background instead of the foreground. |
I think this has probably been around for a while - the pagination on the NTP stuff hasn't landed yet. Fortunately the fix looks pretty straightforward, and should fix #23689 too. |
The above will require |
Verified with
Using STR from #23685 (comment), reproduced the issue using 1.40.113. Observed add/edit dialog behind the grid of top tiles on NTP when adding or editing a site.
Confirmed when using 1.41.94, the add and edit dialogs are not behind the top tiles grid.
|
Description
Edit top sites dialog displays in the background versus foreground. Can still make edits and save.
Steps to Reproduce
Actual result:
edit site is not working properly
Expected result:
Edit dialog displays in the foreground
Reproduces how often:
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: