"Automatically redirect .onion sites" setting is not disabled with Tor

[rillian]

Description

The "Automatically redirect .onion sites" preference stays enabled and clickable even when "Private window with Tor" is disabled. This is confusing because it implies onion-alternate sites will continue to redirect when this is not the case.

Looks like a regression of #17363 possibly because a variable was renamed?

Steps to Reproduce

1. Launch Brave
2. Visit brave://settings/extensions
3. Enable "Automatically redirect .onion sites"
4. Disable "Private window with Tor"

Actual result:

Onion pref is still set and allows interaction

Expected result:

I believe the original design was for it to gray out when Tor was disabled.

Reproduces how often:

Always

Brave version (brave://version info)

Brave: 1.40.96 Chromium: 102.0.5005.115 (Official Build) beta (64-bit)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[stephendonner]

Verification PASSED using

Brave	1.43.56 Chromium: 104.0.5112.81 (Official Build) dev (x86_64)
Revision	5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS	macOS Version 11.6.8 (Build 20G730)

Case one, new profile:

1. install 1.43.56
2. launch Brave
3. opened brave://settings/extensions
4. confirmed Private window with Tor is Enabled by default
5. confirmed Automatically redirect .onion sites was Disabled by default
6. toggled Private window with Tor to Disabled
7. confirmed Private window with Tor is now Disabled
8. confirmed Automatically redirect .onion site is Disabled and ghosted/greyed out
9. toggled Private window with Tor back to Enabled
10. toggled Automatically redirect .onion sites to Enabled
11. toggled Private window with Tor back to Disabled
12. confirmed Automatically redirect .onion sites is set to Enabled but is ghosted/greyed out

step 4	steps 6-8	steps 9-10	step2 11-12

Case two, migration:

1. installed 1.42.86
2. launched Brave
3. opened brave://settings/extensions
4. toggle Private window with Tor to Disabled
5. renamed Brave-Browser profile to Brave-Browser-Dev
6. installed 1.43.56
7. opened brave://settings/extensions
8. confirmed both Private window with Tor and Automatically redirect .onion sites were Disabled
9. additionally, confirmed Automatically redirect .onion sites was ghosted/greyed out

1.42.86	1.43.56

[MadhaviSeelam]

Verification PASSED using

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Case one, new profile:

1. install 1.43.91
2. launch Brave
3. opened brave://settings/extensions
4. confirmed Private window with Tor is Enabled by default
5. confirmed Automatically redirect .onion sites was Disabled by default
6. toggled Private window with Tor to Disabled
7. confirmed Private window with Tor is now Disabled
8. confirmed Automatically redirect .onion site is Disabled and ghosted/greyed out
9. toggled Private window with Tor back to Enabled
10. toggled Automatically redirect .onion sites to Enabled
11. toggled Private window with Tor back to Disabled
12. confirmed Automatically redirect .onion sites is set to Enabled but is ghosted/greyed out
13. clicked on this greyed out state and can't be toggled

step 4	step 5	steps 6-7	step 8	step 9	steps 10	step 11-12

Case two, migration:

1. installed 1.42.97
2. launched Brave
3. opened brave://settings/extensions
4. toggle Private window with Tor to Disabled
5. installed 1.43.91
6. launch Brave
7. confirmed both Private window with Tor and Automatically redirect .onion sites were Disabled
8. additionally, confirmed Automatically redirect .onion sites was ghosted/greyed out
9. clicked on this greyed out state and can't be toggled

1.42.97	1.43.91