Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about filecoin import format #23523

Closed
cypt4 opened this issue Jun 16, 2022 · 2 comments · Fixed by brave/brave-core#13839
Closed

Add note about filecoin import format #23523

cypt4 opened this issue Jun 16, 2022 · 2 comments · Fixed by brave/brave-core#13839
Assignees
@cypt4
Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.41.x - Release

Comments

@cypt4
Copy link

cypt4 commented Jun 16, 2022

Description

image
Here should be a note that says about import format(hex encoded json with private key and protocol)
@cypt4 cypt4 added this to the 1.40.x - Release milestone Jun 16, 2022
@cypt4 cypt4 self-assigned this Jun 16, 2022
@cypt4 cypt4 mentioned this issue Jun 17, 2022
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Jun 17, 2022
@cypt4
Add note when import filecoin private key, also make desc link clickable
f7a62d3 
Resolves brave/brave-browser#23523
Resolves brave/brave-browser#23531
The same note as when export filecoin acc is added
Plaintext link changed to anchor
@brave-builds brave-builds mentioned this issue Jun 17, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above will require 1.41.76 or higher for 1.40.x verification 👍

@srirambv
Copy link
Contributor

Brave 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13839
  • Verified the hex encode message is shown when clicked on Show key
23523-Linux.mp4
23523-Windows.mp4
23523-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Add note when import filecoin private key, also make desc link clickable brave/brave-core
4 participants
@kjozwiak @yrliou @srirambv @cypt4