-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for NetworkService migration #2351
Comments
@tomlowenthal FYI |
Can confirm that Shield becomes ineffective with |
|
When enabled this feature does not instantiate ChromeNetworkDelegate and by its virtue BraveNetworkDelegateBase which is where we add hooks into network stack. Related: brave/brave-browser#2351 Chromium change to not instantiate ChromeNetworkDelegate: commit 4b7d02f22b70c27f32fa5508f785ba310d08aad3 Author: John Abd-El-Malek < [email protected] > Date: Thu May 03 17:46:35 2018 Don't instantiate ChromeNetworkDelegate when network service is enabled. Bug: 598073 Chromium change in C74 to enable network service by default: commit 708db9bc46bec1d0037f44f8fdaff7b7d72724e0 Author: John Abd-El-Malek <[email protected]> Date: Mon Feb 25 18:10:35 2019 +0000 Enable network service on Win/Mac/Linux by default as it launched on stable. Removing running integration tests on these bots (waterfall + CQ). Keep running the layout tests with network service disabled on on debug Linux Tests bots as we're still supporting ChromeOS/Android/Cast which haven't switched over yet. Also remove the disabled-service-worker-servicification virtual test. Bug: 933880,926114
When enabled this feature does not instantiate ChromeNetworkDelegate and by its virtue BraveNetworkDelegateBase which is where we add hooks into network stack. Related: brave/brave-browser#2351 Chromium change to not instantiate ChromeNetworkDelegate: commit 4b7d02f22b70c27f32fa5508f785ba310d08aad3 Author: John Abd-El-Malek < [email protected] > Date: Thu May 03 17:46:35 2018 Don't instantiate ChromeNetworkDelegate when network service is enabled. Bug: 598073 Chromium change in C74 to enable network service by default: commit 708db9bc46bec1d0037f44f8fdaff7b7d72724e0 Author: John Abd-El-Malek <[email protected]> Date: Mon Feb 25 18:10:35 2019 +0000 Enable network service on Win/Mac/Linux by default as it launched on stable. Removing running integration tests on these bots (waterfall + CQ). Keep running the layout tests with network service disabled on on debug Linux Tests bots as we're still supporting ChromeOS/Android/Cast which haven't switched over yet. Also remove the disabled-service-worker-servicification virtual test. Bug: 933880,926114
When enabled this feature does not instantiate ChromeNetworkDelegate and by its virtue BraveNetworkDelegateBase which is where we add hooks into network stack. Related: brave/brave-browser#2351 Chromium change to not instantiate ChromeNetworkDelegate: commit 4b7d02f22b70c27f32fa5508f785ba310d08aad3 Author: John Abd-El-Malek < [email protected] > Date: Thu May 03 17:46:35 2018 Don't instantiate ChromeNetworkDelegate when network service is enabled. Bug: 598073 Chromium change in C74 to enable network service by default: commit 708db9bc46bec1d0037f44f8fdaff7b7d72724e0 Author: John Abd-El-Malek <[email protected]> Date: Mon Feb 25 18:10:35 2019 +0000 Enable network service on Win/Mac/Linux by default as it launched on stable. Removing running integration tests on these bots (waterfall + CQ). Keep running the layout tests with network service disabled on on debug Linux Tests bots as we're still supporting ChromeOS/Android/Cast which haven't switched over yet. Also remove the disabled-service-worker-servicification virtual test. Bug: 933880,926114
When enabled this feature does not instantiate ChromeNetworkDelegate and by its virtue BraveNetworkDelegateBase which is where we add hooks into network stack. Related: brave/brave-browser#2351 Chromium change to not instantiate ChromeNetworkDelegate: commit 4b7d02f22b70c27f32fa5508f785ba310d08aad3 Author: John Abd-El-Malek < [email protected] > Date: Thu May 03 17:46:35 2018 Don't instantiate ChromeNetworkDelegate when network service is enabled. Bug: 598073 Chromium change in C74 to enable network service by default: commit 708db9bc46bec1d0037f44f8fdaff7b7d72724e0 Author: John Abd-El-Malek <[email protected]> Date: Mon Feb 25 18:10:35 2019 +0000 Enable network service on Win/Mac/Linux by default as it launched on stable. Removing running integration tests on these bots (waterfall + CQ). Keep running the layout tests with network service disabled on on debug Linux Tests bots as we're still supporting ChromeOS/Android/Cast which haven't switched over yet. Also remove the disabled-service-worker-servicification virtual test. Bug: 933880,926114
When enabled this feature does not instantiate ChromeNetworkDelegate and by its virtue BraveNetworkDelegateBase which is where we add hooks into network stack. Related: brave/brave-browser#2351 Chromium change to not instantiate ChromeNetworkDelegate: commit 4b7d02f22b70c27f32fa5508f785ba310d08aad3 Author: John Abd-El-Malek < [email protected] > Date: Thu May 03 17:46:35 2018 Don't instantiate ChromeNetworkDelegate when network service is enabled. Bug: 598073 Chromium change in C74 to enable network service by default: commit 708db9bc46bec1d0037f44f8fdaff7b7d72724e0 Author: John Abd-El-Malek <[email protected]> Date: Mon Feb 25 18:10:35 2019 +0000 Enable network service on Win/Mac/Linux by default as it launched on stable. Removing running integration tests on these bots (waterfall + CQ). Keep running the layout tests with network service disabled on on debug Linux Tests bots as we're still supporting ChromeOS/Android/Cast which haven't switched over yet. Also remove the disabled-service-worker-servicification virtual test. Bug: 933880,926114
Please revert this as part of this work: |
upgraded to p1 priority |
As part of migration we have to fix Tor - it doesn't work with enabled NetworkService. It seems that the reason is |
Filed #4312 |
Failed browser test with NS on MacOS.
|
The current plan is to implement our own There is a draft PR with this factory, cargoculted/copypasted from two existing Plumbing easiest individual shield callbacks seems working (not presented in the PR), though porting the whole loop of callbacks that occasionally redirect requests is somewhat bigger task, which I'm doing right now. There is one thing that could be done in parallel with the current stuff - dealing with |
Chromium team is in the middle of a big project, called servicification [1]. One of the most significant parts of it is transition to the Network Service [2].
One of the goals of moving to NS is to avoid storing information in
ProfileIOData
(i.e. cookies), soProfileIOData
will eventually become deprecated. At the moment, the core code of brave shieldsbrave_shields_util.cc
depends onProfileIOData
, so it needs to be reworked in the future. `ChromeNetworkDelegate
itself probably will also be deprecated in favor ofNetworkServiceNetworkDelegate
Deadlines or milestone dates of [1] and [2] are not yet clear.
[1] https://www.chromium.org/servicification
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=598073
The text was updated successfully, but these errors were encountered: