You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you have a user in muon brave who had enabled Payments (wallet exists, etc) but then the user turned Payments off for whatever reason, when I go to import into b-c, Import stalls. I do not have any muon Brave windows open, so the import should succeed.
Steps to Reproduce
Have a muon Brave profile set up where you have Payments data (wallet, etc). Turn off Payments.
Close muon Brave.
Ensure you don't have any Brave-Browser profile for b-c Brave.
Restart your machine (to be extra sure no muon Brave processes are hanging around)
After restart, Launch 0.57.12. I did this from the terminal with /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --enable-logging=stderr --v=0 --vmodule=*rewards*=6
Import only Payments data from Brave (Brave > Import Bookmarks and Settings > choose Brave (old) > only have Payments checked
Actual result:
Import appears to stall. You just get a spinner on the import window.
This displays in terminal:
[891:19203:1203/152148.392986:ERROR:brave_importer.cc(363)] Wallet passphrase not found in session-store-1
[891:19203:1203/152148.393056:ERROR:brave_importer.cc(602)] Failed to parse wallet passphrase
Expected result:
I'd guess that Payments data (wallet) should be imported but Auto Contribute should be disabled.
Payments import will be skipped. No wallet or settings will be imported. See updated pt 11 on Test Plan from brave/brave-core#736
- if session-store-1 and ledger-state.json are missing, skip import
- if rewards is disabled, skip import
- if passphrase or other key fields are missing, skip import
In each of these cases, an error is still logged (to console). But it won't hang the import anymore.
Fixesbrave/brave-browser#2337
Description
If you have a user in muon brave who had enabled Payments (wallet exists, etc) but then the user turned Payments off for whatever reason, when I go to import into b-c, Import stalls. I do not have any muon Brave windows open, so the import should succeed.
Steps to Reproduce
/Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --enable-logging=stderr --v=0 --vmodule=*rewards*=6
Actual result:
Import appears to stall. You just get a spinner on the import window.
This displays in terminal:
Expected result:
I'd guess that Payments data (wallet) should be imported but Auto Contribute should be disabled.Payments import will be skipped. No wallet or settings will be imported. See updated pt 11 on Test Plan from brave/brave-core#736
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: