Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 1PES by default #23180

Closed
goodov opened this issue Jun 1, 2022 · 4 comments · Fixed by brave/brave-core#13900
Closed

Enable 1PES by default #23180

goodov opened this issue Jun 1, 2022 · 4 comments · Fixed by brave/brave-core#13900
Assignees
@goodov
Labels
feature/cookies OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.42.x - Release

Comments

@goodov
Copy link
Member

goodov commented Jun 1, 2022

Enable these features by default in code: BraveFirstPartyEphemeralStorage, BraveDomainBlock1PES.
@goodov goodov self-assigned this Jun 1, 2022
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Jun 22, 2022
@goodov goodov mentioned this issue Jun 22, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 23, 2022
@LaurenWags
Copy link
Member

Could we get a test plan for this issue please? Thanks!

cc @brave/qa-team @rebron

@goodov
Copy link
Member Author

goodov commented Jun 29, 2022 •
edited
Loading

This PR enables two features by default, so they now should be enabled without the Griffin study.
Test cases are similar to the ones in the original task #19099 (comment)
Just need to make sure that you run them without Griffin study being applied (i.e. no FirstPartyEphemeralDomainBlockStudy should be visible on brave://version).

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 19, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Jul 19, 2022 •
edited
Loading

Verified with

Brave | 1.42.69 Chromium: 103.0.5060.114 (Official Build) beta (x86_64)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | macOS Version 12.4 (Build 21F79)

Per #23180 (comment), ran through the cases from #19099 (comment) on initial launch of 1.42.x (that is, did not launch a second time, so griffin seed was not pulled). Also, do not change any flag values on brave://flags when testing this issue.

Case 1: standard mode - PASSED
  1. loaded unusualtitle.com (from this list)
  2. opened brave://settings/cookies
  • Confirmed that unusualtitle.com is present under Sites that clear cookies when you close them
  • Confirmed that there were no cookies or local storage for unusualtitle.com
Example Example Example Example Example
a b c d e
Case 2: aggressive mode - PASSED
  1. set Trackers & ads blocking to Aggressive from the brave://settings/shields dropdown
  2. loaded https://quizzicalzephyr.com
  3. confirmed I saw the blocking interstitial
  4. clicked the Proceed button
  5. opened brave://settings/cookies
  • Confirmed https://quizzicalzephyr.com is added to Sites that clear cookies when you close them in brave://settings/cookies
  • Confirmed there were no cookies or local storage for https://quizzicalzephyr.com
Example Example Example Example Example Example Example
a b c d e f g
Case 3: aggressive mode w/checkbox - PASSED
  1. set Trackers & ads blocking to Aggressive from brave://shields
  2. loaded abtasty.com
  3. confirmed I got a blocking interstitial
  4. clicked the checkbox for Don't warn me about this site again
  5. clicked on Proceed
  6. opened brave://settings/cookies
  • Confirmed abtasty.com is not listed in Sites that clear cookies when you close them
  • Confirmed there were cookies stored
  • Confirmed a few entries in local storage
Example Example Example Example Example Example Example
a b c d e f g
Case 4: Redirect - PASSED

(note - I had Aggressive mode enabled for Ads and Trackers, site doesn't look good this way)

  1. loaded stephendonner.github.io which has a redirect after 3 seconds to 33across.com
  2. confirmed 33across.com was added to Sites that clear cookies when you close them in brave://settings/cookies
Example Example Example Example Example Example
a b c d e f

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 19, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 20, 2022 •
edited by btlechowski
Loading

Verification Complete using

Brave | 1.42.73 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
-- | --
Revision | 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS | Windows 11 Version 21H2 (Build 22000.469)

Per #23180 (comment), ran through the cases from #19099 (comment) on initial launch of 1.42.x (that is, did not launch a second time, so griffin seed was not pulled). Also, do not change any flag values on brave://flags when testing this issue.

Case 1: standard mode - PASSED
  1. loaded https://www.media.net/ (from this list)
  2. opened brave://settings/cookies
  • Confirmed that https://www.media.net/ is present under Sites that clear cookies when you close them
  • Confirmed that there were no cookies or local storage for https://www.media.net/
Example Example Example Example Example
image image image image image
Case 2: aggressive mode - PASSED
  1. Fresh profile
  2. set Trackers & ads blocking to Aggressive from the brave://settings/shields dropdown
  3. loaded raresummer.com
  4. confirmed I saw the blocking interstitial
  5. clicked the Proceed button
  6. opened brave://settings/cookies
  • Confirmed raresummer.com is added to Sites that clear cookies when you close them in brave://settings/cookies
  • Confirmed there were no cookies or local storage for raresummer.com
Example Example Example Example Example Example Example
a image image image image image a
Case 3: aggressive mode w/checkbox - PASSED
  1. set Trackers & ads blocking to Aggressive from brave://shields
  2. loaded https://services.hearstmags.com
  3. confirmed I got a blocking interstitial
  4. clicked the checkbox for Don't warn me about this site again
  5. clicked on Proceed
  6. opened brave://settings/cookies
  • Confirmed services.hearstmags.com is not listed in Sites that clear cookies when you close them
  • Confirmed there were cookies stored
  • Confirmed a few entries in local storage
Example Example Example Example Example Example Example
a image image image image image image
Case 4: Redirect - PASSED
  1. loaded stephendonner.github.io which has a redirect after 3 seconds to 33across.com
  2. confirmed 33across.com was added to Sites that clear cookies when you close them in brave://settings/cookies
Example Example Example Example Example Example
image image image image image image

Verification passed on

Brave 1.42.74 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

Per #23180 (comment), ran through the cases from #19099 (comment) on initial launch of 1.42.x (that is, did not launch a second time, so griffin seed was not pulled). Also, do not change any flag values on brave://flags when testing this issue.

Case 1: standard mode - PASSED
  1. loaded https://www.media.net/ (from this list)
  2. opened brave://settings/cookies
  • Confirmed that https://www.media.net/ is present under Sites that clear cookies when you close them
  • Confirmed that there were no cookies or local storage for https://www.media.net/

image
image

Case 2: aggressive mode - PASSED
  1. Fresh profile
  2. set Trackers & ads blocking to Aggressive from the brave://settings/shields dropdown
  3. loaded raresummer.com
  4. confirmed I saw the blocking interstitial
  5. clicked the Proceed button
  6. opened brave://settings/cookies
  • Confirmed raresummer.com is added to Sites that clear cookies when you close them in brave://settings/cookies
  • Confirmed there were no cookies or local storage for raresummer.com

image
image
image
image
image

Case 3: aggressive mode w/checkbox - PASSED
  1. set Trackers & ads blocking to Aggressive from brave://shields
  2. loaded
  3. confirmed I got a blocking interstitial
  4. clicked the checkbox for Don't warn me about this site again
  5. clicked on Proceed
  6. opened brave://settings/cookies
  • Confirmed services.hearstmags.com is not listed in Sites that clear cookies when you close them
  • Confirmed there were cookies stored
  • Confirmed a few entries in local storage

image
image
image
image

Case 4: Redirect - PASSED
  1. loaded stephendonner.github.io which has a redirect after 3 seconds to 33across.com
  2. confirmed 33across.com was added to Sites that clear cookies when you close them in brave://settings/cookies

image

@LaurenWags LaurenWags mentioned this issue Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodov goodov

Labels
feature/cookies OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Enable 1PES features by default. brave/brave-core
6 participants
@goodov @rebron @LaurenWags @btlechowski @brave-builds @MadhaviSeelam