You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometime after brave/brave-core#736 was merged to master, the behavior of the ledger API seems to have changed. This causes a situation where the import fails
Steps to Reproduce
Fresh profile
Build from source (master)
Have a Muon profile setup, with a Brave Payments wallet (with a balance)
Launch Brave Core
Visit chrome://settings/importData, pick Brave (old), and only choose Brave Payments
Run import process
Actual result:
Calls appear to happen in this order:
Fresh profile; profile write calls CreateWallet
GetWalletProperties (handler) is called BEFORE CreateWallet finishes
GetWalletProperties shows a balance of 0; it attempts to backup the wallet (basically copying the ledger_state file to something like ledger_import_backup_1543557117056)
The CreateWallet call (from step 1) finally finishes- RecoverWallet is now called
The backup kicked off by step 3 finally gets executed; it sees a positive balance (because step 4 has executed). This cancels the import
Expected result:
The code should be robust enough to handle observers firing out of order. For example, in the above, step 2 should be skipped because the wallet hasn't been created yet.
Reproduces how often:
100%
Brave version (brave://version info)
The text was updated successfully, but these errors were encountered:
Description
Sometime after brave/brave-core#736 was merged to master, the behavior of the ledger API seems to have changed. This causes a situation where the import fails
Steps to Reproduce
Brave (old)
, and only chooseBrave Payments
Actual result:
Calls appear to happen in this order:
CreateWallet
GetWalletProperties
(handler) is called BEFORECreateWallet
finishesGetWalletProperties
shows a balance of 0; it attempts to backup the wallet (basically copying theledger_state
file to something likeledger_import_backup_1543557117056
)CreateWallet
call (from step 1) finally finishes-RecoverWallet
is now calledExpected result:
The code should be robust enough to handle observers firing out of order. For example, in the above, step 2 should be skipped because the wallet hasn't been created yet.
Reproduces how often:
100%
Brave version (brave://version info)
The text was updated successfully, but these errors were encountered: