Refactor Tor implementation to retain consistent profile

[tildelowengrimm]

Because private windows with Tor are implemented using guest windows, they don't share anything with the regular profile. Settings aren't inherited, bookmarks aren't present, extensions aren't available, and so on. Instead, windows with Tor should match regular private windows in their interactions with the profile — generally read-only unless someone makes an affirmative action like adding a bookmark.

[durch]

@tomlowenthal looking at unblocking #1677, I'd be willing to sink considerable time into making this happen. Just not sure what would be the best place to start, looking at both the tor_profile_service_factory and the brave_profile_manager I can't figure out where the decision to go with the guest profile is made, a pointer in the right direction would be much appreciated :)

[yrliou]

@durch Hi, just a heads up that I am actively working on refactoring our tor profile stuff to make it align with the incognito profile (profile behind private window) at the moment. #1677 should be unblocked after this is done, thanks!

[durch]

Glad to hear that, is there a branch, or a PR I could follow? Just trying to get some ideas around the timeline.

[yrliou]

@durch At the moment it's still a working in progress in the local, but I will update here if a remote branch or PR is created for you and anyone who is interested to follow the progress, thanks!

[durch]

That sounds awesome @yrliou, thank you!

[yrliou]

With brave/brave-core#3319 merged, we now have settings and bookmarks from the original regular profile, extensions are not ready yet, I'll open a new issue to capture that.

[btlechowski]

Verification passed on

Brave	0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3319
Verified bookmarks and global settings are shared between normal and tor window. Extensions are not shared yet per #2307 (comment)
Verified that brave://settings page is redirected to normal window.
Verified on Clean profile and on upgrade from 0.70.x

Verification passed on

Brave	1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Tor profile rework brave-core#3319
• Verified bookmarks and global settings are shared between normal and tor window. Extensions are not shared yet per Refactor Tor implementation to retain consistent profile #2307 (comment)
• Verified that brave://settings page is redirected to normal window.
• Verified on Clean profile and on upgrade from 0.70.x

Verified passed with

Brave	1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Tor profile rework brave-core#3319
• Verified bookmarks and global settings are shared between normal and tor window. Extensions are not shared yet per Refactor Tor implementation to retain consistent profile #2307 (comment)
• Verified that brave://settings page is redirected to normal window.
• Verified with a clean profile and upgraded (from 1.0.0) profile.