Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Include option for users to hide privacy stats from the NTP #22921

Closed
Brave-Matt opened this issue May 18, 2022 · 32 comments · Fixed by brave/brave-core#16205
Closed
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/new-tab OS/Android Fixes related to Android browser functionality privacy/discussed Discussed in privacy confab privacy/feature User-facing privacy- & security-focused feature work. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@Brave-Matt
Copy link

Brave-Matt commented May 18, 2022

Description

Users should have a way to hide the privacy stats widget from their NTP if desired. I've seen several users make this request and think that it is reasonable and valid, especially considering we allow this option on the desktop version of the browser.
image

Possible solutions/suggestions:

  • Add overflow/three dots menu to stats widget that offers option to hide them
  • Include a toggle option in Settings --> New Tab Page that allows user to toggle the widget on/off
  • Include option in Settings or Main menu to display privacy report (whether widget is toggled on/off or not)

@bradleyrichter @jenn-rhim @SergeyZhukovsky

Additional information

Community thread:
https://community.brave.com/t/how-to-hide-brave-stats-in-android/384365
Internal Slack convo:
https://bravesoftware.slack.com/archives/C0816QH3R/p1651262346660889

@Brave-Matt Brave-Matt added feature/new-tab privacy/feature User-facing privacy- & security-focused feature work. OS/Android Fixes related to Android browser functionality labels May 18, 2022
@bradleyrichter
Copy link

The first desire is to add back the settings toggles as you suggested:

"Include a toggle option in Settings --> New Tab Page that allows user to toggle the widget on/off"

No other UI work is needed until we have privacy stats complete including the label and click area in the stats widget.

@timchilds
Copy link

We could go with the following copy to keep Settings --> New Tab Page consistent:

Show stats widget
On/Off

image

@rmcfadden3 does that copy sound good to you?

@rmcfadden3
Copy link

@timchilds — yeah, copy looks good! ship it!

@angelog0
Copy link

I have the same issue and opened a similar ticket (#22853).

Some year ago I removed Brave from all systems because of this.. then I saw that this was in some manner fixed and I reinstalled it. I find the reintroduction of this issue very irritating. I do not understand the usefulness for the user to know that 32k ads are blocked or that 63 minutes are saved etc.. It is only garbage on the device screen. Why should a programmer waste time in implementing that?

@angelog0
Copy link

BTW, I find that collecting that data is not exactly in line with the policy of the Secure, Fast & Private Web Browser ...

@deeppandya
Copy link

@timchilds @bradleyrichter wouldn't it make sense to keep the settings text similar to desktop version ? we have Show Brave stats and Show top sites in the settings for desktop with switch to toggle.

@timchilds
Copy link

Keeping it consistent with desktop makes sense to me. Unless @bradleyrichter / @rmcfadden3 think otherwise.

@rmcfadden3
Copy link

@deeppandya & @timchilds — sorry, I think I'm missing something. I thought this task was for Settings toggles on whether to "Show background images" and "Show sponsored images" … But @deeppandya looks like you're commenting on a different set of settings RE: showing stats & top sites?

Correct me if I'm totally garbling things here.

@timchilds
Copy link

timchilds commented May 19, 2022

@rmcfadden3 this ticket is to include a setting for users to hide the privacy stats from the NTP.

The two options discussed for the copy:

Option 1
Show stats widget
On/Off

Option 2
Show Brave stats
On/Off

Option 2 is what we currently have on desktop. Let us know which option you think we should use? Option 2 makes sense to me to keep things consistent.

@rmcfadden3
Copy link

@timchilds — oh wow. Apologies. I completely missed that.

Yes, keeping consistent with desktop LGTM.

@bradleyrichter
Copy link

yep. Following desktop will be fine.

image

@srirambv

This comment was marked as outdated.

@deeppandya
Copy link

@srirambv brave/brave-core#13519 only updates code for top sites. It doesnt update anything for brave stats as we need more information to remove it.

@deeppandya deeppandya reopened this Jun 8, 2022
@kjozwiak kjozwiak removed this from the 1.41.x - Nightly milestone Jun 14, 2022
@kjozwiak
Copy link
Member

@srirambv brave/brave-core#13519 only updates code for top sites. It doesnt update anything for brave stats as we need more information to remove it.

Removing the 1.41.x milestone as this wasn't fixed/addressed as per the above. brave/brave-core#13519 only gives the user the ability to disable Top Sites and not the Stats.

@Jpersh27
Copy link

Jpersh27 commented Jul 4, 2022

Hello, I would like to know why this issue hasn't been addressed yet? And why users privacy is not being taken seriously?

There is no reason why your browser needs to keep track of any of my following browser habits:

1.) Trackers & Ads Blocked

2.) Estimated Data Saved

3.) Estimated Time Saved

All that tells me is that even though your ad blocker saves me time, and data, you are still learning my browser habits and behaviors by logging that information.

It takes up a lot of space on my new tab page and is very Intrusive and would like to opt out of the collection of these statistics and remove this widget from the browser.

Can anyone aware of this certain issue provide an update on when this issue will get fixed or why it willn't be or a reason for why there's been no recent discussion in the past 3 weeks about it? @bradleyrichter @timchilds @deeppandya @srirambv @kjozwiak @ShivanKaul @bradleyrichter @jamesmudgett @kylehickinson

Thank you.

@Jpersh27
Copy link

Jpersh27 commented Jul 7, 2022

Hello again,

It has been 3 days now and I haven't been acknowledged in anyway or given a reason for why this issue is being ignored or still unresolved.

It would be much appreciated if someone would respond back with some form of details. At this point I feel as though that any issues being raised by the community are being ignored and put on the “back burner " till further notice for whenever you deem it necessary to address them.

Please persuade me otherwise @bradleyrichter @timchilds @deeppandya @srirambv @kjozwiak @ShivanKaul @bradleyrichter @jamesmudgett @kylehickinson point any information is better than being ignored and shunned by the development team.

Thank you.

@der-p
Copy link

der-p commented Jul 9, 2022

Is there a chance that this will be fixed soon? It's really annoying to me. @bradleyrichter @timchilds @deeppandya @srirambv @kjozwiak @ShivanKaul @bradleyrichter @jamesmudgett @kylehickinson

@deeppandya
Copy link

@Jpersh27 @der-p thank you so much for reaching out to us.
The data we show in brave stats is aggregated only on the client device and not passed in any way to Brave. So we are keeping our brand promise regarding user data protection and privacy. We are looking into providing a proper way to resolve the concern of hiding the stats. Privacy stats is very important for Brave shields so we want to address the issue in a proper way.

@der-p
Copy link

der-p commented Jul 23, 2022

@deeppandya Thank you for your answer. I understand that brave shields is an important feature for you. In general, features provided by Brave should be as optional as possible, since not every user needs and wants all of them. and I think it's not just about where the data is stored. it's about a clean look and feel too. since the desktop version already has the option, the way to implement it properly is already obvious imo. anyway, i'll keep an eye on this and use another chromium fork until then.

@angelog0
Copy link

angelog0 commented Aug 1, 2022

I just upgraded to 1.42.83: same situation described in this issue. Nothing changed since April and, frankly, I am annoyed each time to revert to 1.37 which is the last that works as expected. I do not understand because the Brave developers do not revert their changes regarding this issue to the 1.37 version. ALL THIS IS VERY ANNOIING. I will wait another TWO weeks then I will remove Brave from ALL my device (Win, GNU/Linux, macOS, Android) because I use the same browser on all my systems. I already did so a few year ago. Now I will do that definitively. I am afraid...

@anthonypkeane anthonypkeane added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Aug 9, 2022
@Sam-Sibley
Copy link

Sam-Sibley commented Aug 18, 2022

@anthonypkeane Here is my suggestion for the setting page to toggle off Privacy Report.
@rmcfadden3 Please check this, i am calling them "widgets" to group it with Top sites. Also i have removed the "Show" verb from the item as it is unnecessary as it has a toggle and the state of it directly below.

Hide Privacy Stats

@rmcfadden3
Copy link

@Sam-Sibley — yeah, this lgtm. I think "widgets" is widely understood as a term. Ship it!

@Jpersh27
Copy link

Jpersh27 commented Sep 12, 2022

So @anthonypkeane and @Sam-Sibley and @rmcfadden3 why has this Option not been released yet?

It has been 4 months since this issue was opened. Also been 25 days since you said “ship it".

An explanation would be great, Yes or No?? But I know I'm asking for to much at this point....

As of Beta version 1.44.82 there is still no option to disable it from the homepage. That is very disappointing and doesn't impress me nor convinces me to come back and use the brave web browser.

@timchilds
Copy link

timchilds commented Sep 21, 2022

@deeppandya here is how iOS implemented this: brave/brave-ios#6003

The NTP design (3 dots on privacy stats widget) is in the iOS ticket comments - can we do the same on Android?

The menu design is covered by @Sam-Sibley previous comment.

@deeppandya
Copy link

@timchilds we can definitely do that.

@eataiwo
Copy link

eataiwo commented Nov 22, 2022

Any update on when this fix will be added ?

@snhv
Copy link

snhv commented Nov 28, 2022

Please please allow us to remove the stat in NTP. The mockups proposed here all look good.

@deeppandya
Copy link

Updated design
Screenshot_20221202-125626_Brave - Nightly.jpg
Screenshot_20221202-125615_Brave - Nightly.jpg

@angelog0
Copy link

angelog0 commented Dec 2, 2022

Ok @deeppandya, this has been already described in previous posts in some manner.. but WHEN this will be released???

@deeppandya
Copy link

deeppandya commented Dec 2, 2022

Ok @deeppandya, this has been already described in previous posts in some manner.. but WHEN this will be released???

We have the changes ready to merge. So It will be available on nightly soon.

@snhv
Copy link

snhv commented Dec 2, 2022

Ok @deeppandya, this has been already described in previous posts in some manner.. but WHEN this will be released???

We have the changes ready to merge. So I will be available on nightly soon.

Thanks. That is great to hear!

@stephendonner
Copy link

Verified PASSED using 1.48.134 on a Google Pixel XL (arm64) running Android 9

Steps:

  1. installed 1.48.134
  2. launched Brave
  3. tapped the 3-dots menu
  4. tapped Settings
  5. tapped New Tab Page
  6. confirmed defaults:
    Show Top Sites == On
    Show Brave Stats == On
  7. toggled various combinations of On / Off for the two prefs above

Case 1: Show Top Sites on & Show Brave Stats on - PASSED

new-tab page prefs
Screenshot_20230122-003238 Screenshot_20230122-003249

Case 2: Show Top Sites on & Show Brave Stats off - PASSED

new-tab page prefs
Screenshot_20230122-001007 Screenshot_20230122-001018

Case 3: Show Top Sites off & Show Brave Stats off - PASSED

new-tab page prefs
Screenshot_20230122-001934 Screenshot_20230122-001837

Case 4: Show Top Sites off | Show Brave Stats on - PASSED

new-tab page prefs
Screenshot_20230122-000920 Screenshot_20230122-000930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/new-tab OS/Android Fixes related to Android browser functionality privacy/discussed Discussed in privacy confab privacy/feature User-facing privacy- & security-focused feature work. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.