Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

center the number of trackers on the shields panel - follow up to 21601 #22102

Closed
LaurenWags opened this issue Apr 5, 2022 · 2 comments
Closed
Labels
closed/wontfix feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Apr 5, 2022

Description

Follow up to #21601

When you hover over the trackers/ads blocked (and likely the HTTPS count and blocked scripts count), the number is not centered in the hover area. See screenshots below.

Steps to Reproduce

  1. Visit a page with 99+ trackers/ads blocked (ex. https://d3ward.github.io/toolz/adblock.html)
  2. Open shields
  3. View Advanced if it's not shown
  4. Hover over the 99+ on the same line as "Trackers & ads blocked"

Actual result:

99+ looks like it's right aligned, not centered in the hover area:

Dark theme Light theme
dark light

Expected result:

99+ to be centered in hover area

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.38.80 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 12.3.1 (Build 21E258)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.37.x n/a
  • Can you reproduce this issue with the beta channel? 1.38.x yes
  • Can you reproduce this issue with the nightly channel? 1.39.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags LaurenWags added feature/shields The overall Shields feature in Brave. polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Apr 5, 2022
@rebron
Copy link
Collaborator

rebron commented Apr 5, 2022

cc: @aguscruiz @nullhook

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 5, 2022
@rebron
Copy link
Collaborator

rebron commented Apr 12, 2022

Closing as wontfix. We do want this right aligned.

@rebron rebron closed this as completed Apr 12, 2022
@rebron rebron added closed/wontfix and removed polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants