Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocked count highlight doesn't cover entire number #21601

Closed
stephendonner opened this issue Mar 11, 2022 · 2 comments · Fixed by brave/brave-core#12621
Closed

Blocked count highlight doesn't cover entire number #21601

stephendonner opened this issue Mar 11, 2022 · 2 comments · Fixed by brave/brave-core#12621
Assignees
@rebron @nullhook
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@stephendonner
Copy link

Description

Blocked count highlight doesn't cover entire number

Steps to Reproduce

  1. install 1.38.35
  2. launch Brave
  3. enable Shields V2 via brave://flags
  4. restart Brave
  5. sit on an XHR-happy page (any Facebook one will do)
  6. check the Shields-blocked count via the icon-tip in the URL bar
  7. once it reaches 99+, click on it to expand the flyout panel
  8. click to open its Advanced controls sub-panel
  9. hover over the number for Trackers & ads blocked (standard)
  10. note the highlight paint region

Actual result:

Screen Shot 2022-03-11 at 12 41 01 AM

Expected result:

Should paint the entire number with the hover highlight

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.35 Chromium: 99.0.4844.51 (Official Build) nightly (arm64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 11.6.4 (Build 20G417)

cc @nullhook @rebron @sri
@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. QA/Yes QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Mar 11, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Mar 11, 2022
@rebron
Copy link
Collaborator

rebron commented Mar 11, 2022

We stopped at 99+ for Shield v1. Need a decision here if we want to go with actual numbers in v2.

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Mar 11, 2022
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Mar 15, 2022
@nullhook nullhook mentioned this issue Mar 16, 2022
Merged
25 tasks
@nullhook nullhook added this to the 1.38.x - Nightly milestone Mar 18, 2022
@stephendonner
Copy link
Author

stephendonner commented Mar 21, 2022 •
edited
Loading

Verified PASSED using

Brave 1.38.60 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.3 (Build 20G415)

Confirmed Shields' blocked count changes to 99+ when it hits 99.

0 1 <99 99+ details
Screen Shot 2022-03-21 at 10 57 56 AM Screen Shot 2022-03-21 at 10 50 53 AM Screen Shot 2022-03-21 at 10 56 18 AM Screen Shot 2022-03-21 at 10 57 15 AM Screen Shot 2022-03-21 at 10 57 23 AM

@LaurenWags LaurenWags mentioned this issue Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebron rebron

@nullhook nullhook

Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Truncate block count numbers on shields panel v2 brave/brave-core
3 participants
@stephendonner @rebron @nullhook