Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor userVisibleTokensInfo and fullTokenList to have chainId name-spacing #21770

Closed
Douglashdaniel opened this issue Mar 18, 2022 · 0 comments · Fixed by brave/brave-core#15519
Closed

Refactor userVisibleTokensInfo and fullTokenList to have chainId name-spacing #21770

Douglashdaniel opened this issue Mar 18, 2022 · 0 comments · Fixed by brave/brave-core#15519
Assignees
@Douglashdaniel
Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/exclude
Milestone
1.47.x - Release

Comments

@Douglashdaniel
Copy link

Description

Refactor userVisibleTokensInfo and fullTokenList to have name name-spacing by chainId similar to what we do for tokenBalanceRegistry and nativeBalanceRegistry
@Douglashdaniel Douglashdaniel added dev-concern feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 18, 2022
@Douglashdaniel Douglashdaniel self-assigned this Mar 18, 2022
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 18, 2022
@Douglashdaniel Douglashdaniel moved this to Backlog in Web3 Mar 18, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Mar 18, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel mentioned this issue Oct 18, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from Backlog to In Review in Web3 Oct 18, 2022
Repository owner moved this from In Review to Done in Web3 Oct 21, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Edit Visible Assets Network Selector brave/brave-core
2 participants
@Douglashdaniel @brave-builds