Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom amounts for Brave Rewards not showing in drop down #2152

Closed
bsclifton opened this issue Nov 15, 2018 · 3 comments · Fixed by brave/brave-core#910
Closed

Custom amounts for Brave Rewards not showing in drop down #2152

bsclifton opened this issue Nov 15, 2018 · 3 comments · Fixed by brave/brave-core#910

Comments

@bsclifton
Copy link
Member

bsclifton commented Nov 15, 2018

Test plan

See brave/brave-core#910

Description

While implementing brave/brave-core#736 I noticed that custom amounts (ex: values not in the drop-down) are not being added to the drop-down after being set via RewardsServiceImpl::SetContributionAmount.

Steps to Reproduce / test plan for peer review

  1. Build from master
  2. In the code somewhere, call RewardsServiceImpl::SetContributionAmount and pass a value like 13
  3. Visit brave://rewards and notice that the amount is not shown in the drop down

Actual result:

For me it defaulted to 20?

Expected result:

It should show 13

Reproduces how often:

100%

Brave version (brave://version info)

master (brave/brave-core@d76c724)

Reproducible on current release:

n/a, since it involves writing code (discovered while importing from Muon)

@NejcZdovc
Copy link
Contributor

@kjozwiak @rebron @srirambv set this to 0.57 so it will be fixed for muon import. Please adjust it if you think we should not land it there

@NejcZdovc
Copy link
Contributor

adde QA/No as we don't have good steps for QA to use

NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 19, 2018
@NejcZdovc NejcZdovc added QA/Yes and removed QA/No labels Nov 19, 2018
bsclifton pushed a commit to brave/brave-core that referenced this issue Nov 20, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 3, 2018

Verification passed on

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Windows

Verified passed with

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Mac OS X

Verification passed on

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment