-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom amounts for Brave Rewards not showing in drop down #2152
Labels
Milestone
Comments
18 tasks
adde QA/No as we don't have good steps for QA to use |
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Nov 19, 2018
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Nov 20, 2018
Verification passed on
Verified passed with
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Test plan
See brave/brave-core#910
Description
While implementing brave/brave-core#736 I noticed that custom amounts (ex: values not in the drop-down) are not being added to the drop-down after being set via
RewardsServiceImpl::SetContributionAmount
.Steps to Reproduce / test plan for peer review
RewardsServiceImpl::SetContributionAmount
and pass a value like 13brave://rewards
and notice that the amount is not shown in the drop downActual result:
For me it defaulted to 20?
Expected result:
It should show 13
Reproduces how often:
100%
Brave version (brave://version info)
master (brave/brave-core@d76c724)
Reproducible on current release:
n/a, since it involves writing code (discovered while importing from Muon)
The text was updated successfully, but these errors were encountered: