Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus handling when sidebar panel webview is opened and closed #21393

Closed
simonhong opened this issue Mar 2, 2022 · 4 comments · Fixed by brave/brave-core#12459
Closed

Focus handling when sidebar panel webview is opened and closed #21393

simonhong opened this issue Mar 2, 2022 · 4 comments · Fixed by brave/brave-core#12459

Comments

@simonhong
Copy link
Member

simonhong commented Mar 2, 2022

When sidebar panel opens, give focus to sidebar panel.
When sidebar panel closes, clear focus. Browser window's root view will get focused.

STR 1 - panel open

  1. Open sidebar bookmarks panel
  • Actual result - bookmarks panel don't have focus
  • Expected result - bookmarks panel has focus
    After opening bookmarks panel, first tab gives focus to first element in the panel

STR 2 - panel close

  1. Open sidebar bookmarks panel
  2. Click any area in sidebar bookmarks panel to get focus
  3. Close sidebar bookmarks panel
  • Actual result - web page in active tab gets focused always.
    If active tab is github.com, we can see below Skip to content element after panel is closed.
    image
  • Expected result - Focus is cleared
@simonhong simonhong self-assigned this Mar 2, 2022
simonhong added a commit to brave/brave-core that referenced this issue Mar 4, 2022
fix brave/brave-browser#21393

When sidebar panel is opened, it will get focused.
When panel is closed, current focus is cleared.
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 4, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 11, 2022

Requires 1.37.90 or higher for QA verification's via 1.37.x.

@stephendonner
Copy link

Verified PASSED using

Brave 1.37.90 Chromium: 99.0.4844.51 (Official Build) beta (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 12.3 (Build 21E230)

Case One: panel open

  1. installed 1.37.90
  2. launched Brave
  3. clicked on the Bookmarks icon in the Sidebar
  4. to check focus, pressed tab

Confirmed tab cycled through UI elements in their index

example example
Screen Shot 2022-03-13 at 3 33 27 AM Screen Shot 2022-03-13 at 3 33 33 AM

Case Two: panel close

  1. installed 1.37.90
  2. launched Brave
  3. clicked on the Bookmarks icon in the Sidebar
  4. clicked to expand a folder with a bookmark
  5. pressed tab to select the bookmark
  6. clicked on the Bookmarks icon in the Sidebar to close the panel

Confirmed NO Skip to content (from test plan) present on panel close. (I was able to trigger that accessibility navigation hint normally via tab which is expected in that context.)

example example
Screen Shot 2022-03-13 at 3 41 18 AM Screen Shot 2022-03-13 at 3 41 24 AM

@btlechowski
Copy link

Verification passed on

Brave 1.37.95 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Ubuntu 18.04 LTS

Verified test plan from the description

panel open

Verified bookmarks panel has focus
image

panel close

Verified focus is cleared
image

@MadhaviSeelam
Copy link

Verified 'Passed' using

  Brave |	1.37.98 Chromium: 99.0.4844.74 (Official Build) beta (64-bit) 
  --|--
  Revision |	fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
  OS |	Windows 11 Version 21H2 (Build 22000.556)

Case One: panel open

  • installed 1.37.98
  • launched Brave
  • clicked on the Bookmarks icon in the Sidebar
  • to check focus, pressed tab to focus on the first element in the panel
  • Confirmed tab cycled through UI elements in their index
panel open

CASE ONE

Case Two: panel close

  • installed 1.37.98
  • launched Brave
  • clicked on the Bookmarks icon in the Sidebar
  • clicked to expand a folder with a bookmark
  • pressed tab to get focus
  • Clicked on the Bookmarks icon in the Sidebar to close the panel
  • Confirmed NO Skip to content (from test plan) present on panel close.
panel close

CASE TWO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment