-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus handling when sidebar panel webview is opened and closed #21393
Labels
feature/sidebar
Relating to Brave's Sidebar feature
OS/Desktop
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
simonhong
added
QA/Yes
release-notes/exclude
OS/Desktop
feature/sidebar
Relating to Brave's Sidebar feature
labels
Mar 2, 2022
25 tasks
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Mar 4, 2022
fix brave/brave-browser#21393 When sidebar panel is opened, it will get focused. When panel is closed, current focus is cleared.
7 tasks
Requires |
Verified
|
Brave | 1.37.90 Chromium: 99.0.4844.51 (Official Build) beta (x86_64) |
---|---|
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875} |
OS | macOS Version 12.3 (Build 21E230) |
Case One: panel open
- installed
1.37.90
- launched Brave
- clicked on the
Bookmarks
icon in the Sidebar - to check focus, pressed
tab
Confirmed tab
cycled through UI elements in their index
example | example |
---|---|
Case Two: panel close
- installed
1.37.90
- launched Brave
- clicked on the
Bookmarks
icon in the Sidebar - clicked to expand a folder with a bookmark
- pressed
tab
to select the bookmark - clicked on the
Bookmarks
icon in the Sidebar to close the panel
Confirmed NO Skip to content
(from test plan) present on panel close. (I was able to trigger that accessibility navigation hint normally via tab
which is expected in that context.)
example | example |
---|---|
Verification passed on
Verified test plan from the description panel openVerified bookmarks panel has focus panel close |
Verified 'Passed' using
Case One: panel open
Case Two: panel close
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/sidebar
Relating to Brave's Sidebar feature
OS/Desktop
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
When sidebar panel opens, give focus to sidebar panel.
When sidebar panel closes, clear focus. Browser window's root view will get focused.
STR 1 - panel open
After opening bookmarks panel, first tab gives focus to first element in the panel
STR 2 - panel close
If active tab is github.com, we can see below
Skip to content
element after panel is closed.The text was updated successfully, but these errors were encountered: