Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN button text should be theme/contrast-aware #21242

Closed
Tracked by #15804
stephendonner opened this issue Feb 22, 2022 · 2 comments · Fixed by brave/brave-core#12675
Closed
Tracked by #15804

VPN button text should be theme/contrast-aware #21242

stephendonner opened this issue Feb 22, 2022 · 2 comments · Fixed by brave/brave-core#12675
Assignees
@simonhong
Labels
bug feature/vpn OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No QA Pass-macOS QA/Test-Plan-Specified release-notes/exclude
Milestone
1.38.x - Release

Comments

@stephendonner
Copy link

Description

VPN button text should be theme/contrast-aware

Steps to Reproduce

  1. install 1.37.65
  2. launch Brave
  3. load brave://flags
  4. set Enable experimental Brave VPN to Enabled
  5. click to Relaunch
  6. open brave://settings/manageProfile
  7. choose a white/very light color set
  8. look at the VPN text in the button on the browser toolbar

Actual result:

It's hard to read VPN text due to being white-on-white.

white-on-white

Expected result:

The VPN text on the button should be theme/contrast-aware.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.37.65 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 10 Version 21H2 (Build 19044.1566)

cc @simonhong @nullhook
@stephendonner stephendonner mentioned this issue Feb 22, 2022
Closed
@simonhong simonhong self-assigned this Feb 22, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Feb 25, 2022
simonhong added a commit to brave/brave-core that referenced this issue Mar 20, 2022
@simonhong
Picked brave vpn button colors based on toolbar color
d8d77c0 
fix brave/brave-browser#21242

VPN Button's colors are selected by choosing most contrasted colors
based on current toolbar color.
@simonhong simonhong mentioned this issue Mar 20, 2022
Merged
25 tasks
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 21, 2022
@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.38.60 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.3 (Build 20G415)

Confirmed VPN text is still visible, changing profiles to light and dark colors

example example example example
Screen Shot 2022-03-21 at 12 08 01 PM Screen Shot 2022-03-21 at 12 08 27 PM Screen Shot 2022-03-21 at 12 09 12 PM Screen Shot 2022-03-21 at 12 09 40 PM

@LaurenWags
Copy link
Member

Changing to QA/No per discussion in today's desktop planning meeting, testing will be covered with #15804.

@LaurenWags LaurenWags added QA/No and removed QA/Yes labels Apr 5, 2022
@bsclifton bsclifton mentioned this issue Apr 6, 2022
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/vpn OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No QA Pass-macOS QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Picked brave vpn button colors based on toolbar color brave/brave-core
4 participants
@stephendonner @rebron @simonhong @LaurenWags