Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colored brave talk icon when there already opened tab for brave talk #20865

Closed
simonhong opened this issue Feb 3, 2022 · 1 comment · Fixed by brave/brave-core#12137
Closed

Comments

@simonhong
Copy link
Member

simonhong commented Feb 3, 2022

Test plan

  1. Fresh install
  2. Ensure sidebar is showing (or enable if needed)
  3. Click Brave talk icon on the sidebar
  4. Brave Talk icon in sidebar should change from gray outline to a colored outline
  5. Open another talk.brave.com link in another tab
  6. Verify the Brave Talk sidebar button cycles between both pages
  7. Close both Brave Talk tabs
  8. Verify Brave Talk sidebar icon is back to gray outline

Description

Like below image, brave talk icon should be colored when browser has tab that loads brave talk at least one.
Screenshot from 2022-02-03 11-39-10

If browser doesn't include brave talk tab, icon will not be colored one.

@simonhong simonhong self-assigned this Feb 3, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 4, 2022
@bsclifton bsclifton added this to the 1.37.x - Nightly milestone Feb 8, 2022
@stephendonner
Copy link

stephendonner commented Feb 9, 2022

Verified PASSED using

Brave 1.37.36 Chromium: 98.0.4758.87 (Official Build) nightly (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Windows 10 Version 21H2 (Build 19044.1466)

Steps:

  1. installed 1.37.36
  2. loaded brave://flags
  3. set Enable Sidebar to Enabled
  4. clicked Relaunch
  5. loaded talk.brave.com (1), nbcnews.com, and talk.brave.com (2) in tabs
  6. confirmed the Brave Talk icon changed to its colored version
  7. clicked on the nbcnews.com (middle) tab
  8. clicked on the Brave Talk icon in Sidebar
  9. confirmed I cycled to the right, to the talk.brave.com (2) tab
  10. clicked it again
  11. confirmed I cycled back to the left, to the original talk.brave.com (1) tab
  12. closed both Brave Talk tabs
  13. confirmed the Brave Talk icon went back to gray
step 2 step 6 step 9 step 11 step 13
20865-1 20865-4 20865-5 20865-4 20865-7

light mode:

20865-8


Verified PASSED using

Brave 1.37.91 Chromium: 99.0.4844.51 (Official Build) beta (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 12.3 (Build 21E230)

Steps:

  1. installed 1.37.91
  2. loaded talk.brave.com (1), nbcnews.com, and talk.brave.com (2) in tabs
  3. confirmed the Brave Talk icon changed to its colored version
  4. clicked on the nbcnews.com (middle) tab
  5. clicked on the Brave Talk icon in Sidebar
  6. confirmed I cycled to the right, to the talk.brave.com (2) tab
  7. clicked it again
  8. confirmed I cycled back to the left, to the original talk.brave.com (1) tab
  9. closed both Brave Talk tabs
  10. confirmed the Brave Talk icon went back to gray
step 3 step 6 step 8 step 10
Screen Shot 2022-03-14 at 6 44 25 PM Screen Shot 2022-03-14 at 6 45 02 PM Screen Shot 2022-03-14 at 6 45 09 PM Screen Shot 2022-03-14 at 6 45 21 PM

dark mode:

Screen Shot 2022-03-14 at 6 50 29 PM


Verification passed on

Brave 1.37.95 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Ubuntu 18.04 LTS

confirmed the Brave Talk icon changed to its colored version
image

confirmed I cycled to the right, to the talk.brave.com (2) tab
image

confirmed I cycled back to the left, to the original talk.brave.com (1) tab
image

confirmed the Brave Talk icon went back to gray
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants