Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems casting votes on Snapshot w/ Ledger #20864

Closed
bbondy opened this issue Feb 3, 2022 · 3 comments · Fixed by brave/brave-core#12206
Closed

Problems casting votes on Snapshot w/ Ledger #20864

bbondy opened this issue Feb 3, 2022 · 3 comments · Fixed by brave/brave-core#12206
Assignees
@spylogsster
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Feb 3, 2022

https://community.brave.com/t/error-when-trying-to-sign-cast-vote-on-snapshot-org-with-ledger-via-brave-wallet/332945
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 3, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2022
@Pharkie
Copy link

Pharkie commented Feb 5, 2022

Yes, same exact issue. Makes Brave Wallet unusable for me and going back to Metamask 😮‍💨

@spylogsster spylogsster self-assigned this Feb 7, 2022
@spylogsster spylogsster mentioned this issue Feb 10, 2022
Merged
25 tasks
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 11, 2022
@brave-builds brave-builds mentioned this issue Feb 11, 2022
Merged
7 tasks
@srirambv srirambv added QA/No and removed QA/Yes labels Feb 14, 2022
@srirambv srirambv added QA/Yes and removed QA/No labels Feb 18, 2022
@srirambv
Copy link
Contributor

@spylogsster provided a test plan for this so will be testing it on the beta build

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Feb 22, 2022
@srirambv
Copy link
Contributor

Verification passed as part of #18833 (comment). Confirmed with @spylogsster verification from #18833 is sufficient

@bbondy bbondy changed the title Report of casting votes on snapshot w/ Ledger Problems casting votes on snapshot w/ Ledger Mar 1, 2022
@bbondy bbondy changed the title Problems casting votes on snapshot w/ Ledger Problems casting votes on Snapshot w/ Ledger Mar 1, 2022
@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Fix Ledger messages signatures brave/brave-core
6 participants
@bbondy @Pharkie @kjozwiak @spylogsster @srirambv @LaurenWags