Brave Rewards panel can have a mismatch for icon and URL

[bbondy]

Description

Sometimes there's a mismatch for icon and name in the rewards panel.

Steps to Reproduce

Unsure of the exact steps, but probably something like go to calendar.google.com first, then google.com.

Actual result:

google.com is displayed as the name
chrome://favicon/size/48@1x/https://calendar.google.com/ is displayed as the icon.

Both going to google.com and calendar.google.com displays the same way as per the screenshot above.

Expected result:

It displays consistent results.

Reproduces how often:

Always on my open window.

Brave version (brave://version info)

0.56.10

Reproducible on current release:

Yes,

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? Yes.
• Is the issue reproducible on the latest version of Chrome? N/a.

[LaurenWags]

@NejcZdovc two questions:

1. test plan from Fixes subdomain logging for rewards brave-core#1030 works, but I have to refresh brave://rewards to see the favicon for brave.com at the end of the test plan. Is this expected?
2. stats.brave.com doesn't have a favicon
   
   so when I substitute a different site that does have a favicon, such as technology.slashdot.org, i see the same result (no favicon in Rewards until I visit slashdot.org). Is this expected?

[NejcZdovc]

@LaurenWags re 1 and 2: yes expected. For 2 we use chromium favicon system and because you didn't visit root domain yet we don't have favicon for it

[LaurenWags]

Verified passed with

Brave	0.60.19 Chromium: 72.0.3626.81 (Official Build) beta(64-bit)
Revision	ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS	Mac OS X

• Verified test plan from Fixes subdomain logging for rewards brave-core#1030 and saw that at the end, brave://rewards had to be refreshed to see the favicon. Verified in comments above that this is expected.

Verification passed on

Brave	0.60.25 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Windows 10

• Verified test plan from Fixes subdomain logging for rewards brave-core#1030

Verification passed on

Brave	0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Linux

• Verified test plan from Fixes subdomain logging for rewards brave-core#1030