Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatAdsTimeUtilTest* tests are failing under MacOS64 #20183

Closed
aseren opened this issue Dec 21, 2021 · 0 comments · Fixed by brave/brave-core#11657
Closed

BatAdsTimeUtilTest* tests are failing under MacOS64 #20183

aseren opened this issue Dec 21, 2021 · 0 comments · Fixed by brave/brave-core#11657
Assignees
@aseren
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude tests
Milestone
1.35.x - Release

Comments

@aseren
Copy link

aseren commented Dec 21, 2021

10:47:26 6 tests failed:
10:47:26 BatAdsTimeUtilTest.AdjustTimeToBeginningOfMonth/1 (../../brave/vendor/bat-native-ads/src/bat/ads/internal/time_util_unittest.cc:155)
10:47:26 BatAdsTimeUtilTest.AdjustTimeToBeginningOfPreviousMonth/1 (../../brave/vendor/bat-native-ads/src/bat/ads/internal/time_util_unittest.cc:91)
10:47:26 BatAdsTimeUtilTest.AdjustTimeToEndOfPreviousMonth/1 (../../brave/vendor/bat-native-ads/src/bat/ads/internal/time_util_unittest.cc:123)
10:47:26 BatAdsTimeUtilTest.GetTimeAtBeginningOfLastMonth/1 (../../brave/vendor/bat-native-ads/src/bat/ads/internal/time_util_unittest.cc:187)
10:47:26 BatAdsTimeUtilTest.GetTimeAtBeginningOfThisMonth/1 (../../brave/vendor/bat-native-ads/src/bat/ads/internal/time_util_unittest.cc:251)
10:47:26 BatAdsTimeUtilTest.GetTimeAtEndOfLastMonth/1 (../../brave/vendor/bat-native-ads/src/bat/ads/internal/time_util_unittest.cc:219)
@aseren aseren self-assigned this Dec 21, 2021
aseren added a commit to brave/brave-core that referenced this issue Dec 21, 2021
@aseren
Fix conversion in daylight saving started/ended months.
a9a9b1d 
fix brave/brave-browser#20183
@aseren aseren mentioned this issue Dec 21, 2021
Merged
25 tasks
@tmancey tmancey added this to the 1.35.x - Nightly milestone Dec 21, 2021
@tmancey tmancey added QA/No release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. bug feature/ads labels Dec 21, 2021
@tmancey tmancey mentioned this issue Dec 21, 2021
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude tests
Projects
Ads
Archived in project
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Fix conversion in daylight saving started/ended months. brave/brave-core
2 participants
@tmancey @aseren