Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 97.0.4692.45 to Chromium 97.0.4692.56. #20119

Closed
mkarolin opened this issue Dec 15, 2021 · 5 comments · Fixed by brave/brave-core#11618
Closed

Upgrade from Chromium 97.0.4692.45 to Chromium 97.0.4692.56. #20119

mkarolin opened this issue Dec 15, 2021 · 5 comments · Fixed by brave/brave-core#11618

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/97.0.4692.45..97.0.4692.56?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@LaurenWags
Copy link
Member

@mkarolin should this be in the 1.34.x milestone? I believe 1.34.67 has this CR bump

Brave | 1.34.67 Chromium: 97.0.4692.56 (Official Build) beta (x86_64)
-- | --
Revision | 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS | macOS Version 11.6.1 (Build 20G224)

@LaurenWags
Copy link
Member

@brave/legacy_qa please be sure to check all appropriate affected areas from #18954 when testing this issue.

@btlechowski
Copy link

btlechowski commented Dec 24, 2021

Verification passed on

Brave 1.34.71 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Ubuntu 18.04 LTS

image

Page Info bubble for HTTP(S) and IPFS sites

Secure site

image

Non-secure site

image

IPFS sites

image
image

brave://about

Confirmed all the links are present in brave://about except the links below, which is expected as per the https://bravesoftware.slack.com/archives/C7VLGSR55/p1639677663306800

brave://appcache-internals
brave://devices
brave://network-error
brave://ppapiflashcrash/
brave://ppapiflashhang/
Close button on tabs

image
image
image

Setting UI

image
image
image
image
image
image
image


Verification passed on


Brave | 1.34.73 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
-- | --
Revision | 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS | Windows 10 Version 21H2 (Build 19044.1415)

image

Additional testing is covered in #18954 (comment)


Verified PASSED using

Brave 1.34.74 Chromium: 97.0.4692.56 (Official Build) beta (x86_64)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS macOS Version 11.6.1 (Build 20G224)

Screen Shot 2021-12-28 at 10 47 35 AM

Page info bubble for HTTP(S) and IPFS sites Screen Shot 2021-12-28 at 10 49 37 AM Screen Shot 2021-12-28 at 10 50 51 AM Screen Shot 2021-12-28 at 10 51 31 AM Screen Shot 2021-12-28 at 10 51 34 AM
brave://about Confirmed all the links are present in brave://about except the links below, which is expected as per the https://bravesoftware.slack.com/archives/C7VLGSR55/p1639677663306800
brave://appcache-internals
brave://devices
brave://network-error
brave://ppapiflashcrash/
brave://ppapiflashhang/
Close button on tabs Screen Shot 2021-12-28 at 10 54 38 AM Screen Shot 2021-12-28 at 10 54 47 AM
Settings UI Screen Shot 2021-12-28 at 10 56 29 AM Screen Shot 2021-12-28 at 10 56 38 AM Screen Shot 2021-12-28 at 10 56 43 AM Screen Shot 2021-12-28 at 10 56 46 AM Screen Shot 2021-12-28 at 10 56 50 AM Screen Shot 2021-12-28 at 10 57 31 AM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 28, 2021

Verification PASSED on Galaxy Tab A7 version running Bravemonoarm64.apk_1.34.74

Settings UI
  • Verified all the settings from the hamburger menu and confirmed all the settings are working as expected
  • Confirmed no new settings are added
Example Example
Screenshot_20211229-174830_Brave - Beta Screenshot_20211229-174837_Brave - Beta
New tab page
  • Confirmed NTP controls are working as expected
  • Confirmed NTP SI is shown on the NTP
  • Confirmed Top tiles are shown on NTP
  • Confirmed NTP stats are shown correctly
Example Example
Screenshot_20211229-174609_Brave - Beta Screenshot_20211229-174601_Brave - Beta
Sync
Private page UI
  • Confirmed Private tab page icons are displayed as expected
  • Confirmed Private tab page content message is displayed as expected
  • Confirmed sites can be opened via the Private tab
Bookmarks
  • Confirmed bookmarks can be created
  • Confirmed bookmarks can be added to folders
  • Confirmed bookmarks can be edited/deleted/moved up/moved down
  • Confirmed bookmarks can be moved between the folders
  • Confirmed bookmarks folders can be deleted

@stephendonner
Copy link

stephendonner commented Dec 30, 2021

Verification PASSED using Brave 1.34.76, Chromium 97.0.4692.56 on a Google Pixel XL running Android 9.0

Screenshot_20211229-184616

Settings UI
  • Verified all the settings from the hamburger menu and confirmed all the settings are working as expected
  • Confirmed no new settings are added
Example Example Example
Screenshot_20211229-185006 Screenshot_20211229-185027 Screenshot_20211229-185036
New tab page
  • Confirmed NTP controls are working as expected
  • Confirmed NTP SI is shown on the NTP
  • Confirmed Top tiles are shown on NTP
  • Confirmed NTP stats are shown correctly
Example Example
Screenshot_20211229-185121 Screenshot_20211229-185130
Sync
Private page UI
Example Example
Screenshot_20211229-185246 Screenshot_20211229-185259
  • Confirmed Private tab page icons are displayed as expected
  • Confirmed Private tab page content message is displayed as expected
  • Confirmed sites can be opened via the Private tab
Bookmarks
  • Confirmed bookmarks can be created
  • Confirmed bookmarks can be added to folders
  • Confirmed bookmarks can be edited/deleted/moved up/moved down
  • Confirmed bookmarks can be moved between the folders
  • Confirmed bookmarks folders can be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment