Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCHECK failure from ads::AdjustTimeToBeginningOfMonth() #20104

Closed
simonhong opened this issue Dec 15, 2021 · 2 comments · Fixed by brave/brave-core#11645
Closed

DCHECK failure from ads::AdjustTimeToBeginningOfMonth() #20104

simonhong opened this issue Dec 15, 2021 · 2 comments · Fixed by brave/brave-core#11645
Assignees
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@simonhong
Copy link
Member

simonhong commented Dec 15, 2021

In linux local build, I got below DCHECK failure after enabling rewards.

I built with some npm params shared at https://bravesoftware.slack.com/archives/CB0KCRCQN/p1639545725306400?thread_ts=1639532797.297000&cid=CB0KCRCQN

#0 0x7f4559dba459 base::debug::CollectStackTrace()
#1 0x7f4559cb42d3 base::debug::StackTrace::StackTrace()
#2 0x7f4559db9ee1 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f45487383c0 (/usr/lib/x86_64-linux-gnu/libpthread-2.31.so+0x153bf)
#4 0x7f4547dc3941 abort
#5 0x7f4559db9065 base::debug::BreakDebuggerAsyncSafe()
#6 0x7f4559cd6e8b logging::LogMessage::~LogMessage()
#7 0x7f4559cd74ae logging::LogMessage::~LogMessage()
#8 0x5573bd6c7068 ads::AdjustTimeToBeginningOfMonth()
#9 0x5573bd6c70da ads::GetTimeAtBeginningOfThisMonth()
#10 0x5573bd5ee681 ads::GetEarningsForThisMonth()
#11 0x5573bd5ee3ce std::__Cr::__function::__policy_invoker<>::__call_impl<>()
#12 0x5573bd66f048 ads::database::table::Transactions::OnGetTransactions()
#13 0x5573bd6545c9 _ZNSt4__Cr6__bindIMN3ads8database10InitializeEFvN4mojo9StructPtrINS1_5mojom17DBCommandResponseEEENS_8functionIFvbEEEEJPS3_RKNS_12placeholders4__phILi1EEERSB_EEclIJS8_EEENS_13__bind_returnISD_NS_5tupleIJSE_SH_SB_EEENSO_IJDpOT_EEEXsr22__is_valid_bind_returnISD_SP_ST_EE5valueEE4typeESS_
#14 0x5573bfbdef8b bat_ads::OnRunDBTransaction()
#15 0x5573bfbdf7c2 base::internal::Invoker<>::RunOnce()
#16 0x5573bda6418e bat_ads::mojom::BatAdsClient_RunDBTransaction_ForwardToCallback::Accept()

cc @aseren

@stephendonner
Copy link

@aseren is there a testplan for this? i.e. regression test(s) or other? Or can it be marked as QA/No as it seems covered partially by unittests? 🙏

@aseren
Copy link

aseren commented Jan 17, 2022

Sorry for missing a test plan. Current issue could be tested here: #20204

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants