Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Brave Talk widget default in NTP stack #20015

Closed
mattmcalister opened this issue Dec 9, 2021 · 3 comments · Fixed by brave/brave-core#11605
Closed

Make Brave Talk widget default in NTP stack #20015

mattmcalister opened this issue Dec 9, 2021 · 3 comments · Fixed by brave/brave-core#11605
Assignees
@rebron @simonhong
Labels
feature/new-tab needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@mattmcalister
Copy link

mattmcalister commented Dec 9, 2021 •
edited
Loading

Show Brave Talk widget on NTP by default by changing default visibility to visible. (Updated based on comment from @simonhong )
@rebron rebron added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. feature/new-tab labels Dec 10, 2021
@simonhong
Copy link
Member

How about changing widget's default visibility to visible?
By making it visible, existing users that have not customized it's visiblity and new users will see talk widget.
If users already modified its visibility, default value change doesn't affect to those users.

@mattmcalister
Copy link
Author

How about changing widget's default visibility to visible? By making it visible, existing users that have not customized it's visiblity and new users will see talk widget. If users already modified its visibility, default value change doesn't affect to those users.

That makes more sense, actually, yes. I've updated the original description.

simonhong added a commit to brave/brave-core that referenced this issue Dec 15, 2021
@simonhong
Make brave talk widget visible by default
18ab31c 
fix brave/brave-browser#20015
@simonhong simonhong mentioned this issue Dec 15, 2021
Merged
25 tasks
@simonhong simonhong self-assigned this Dec 15, 2021
simonhong added a commit to brave/brave-core that referenced this issue Jan 20, 2022
@simonhong
Make brave talk widget visible by default
5cd77f9 
fix brave/brave-browser#20015
@simonhong simonhong added this to the 1.36.x - Nightly milestone Jan 25, 2022
@stephendonner
Copy link

stephendonner commented Jan 25, 2022 •
edited
Loading

Verified PASSED using

Brave 1.36.66 Chromium: 98.0.4758.66 (Official Build) nightly (x86_64)
Revision db1b4001d5ce29f141297f260d2b778e000b85a3-refs/branch-heads/4758@{#762}
OS macOS Version 11.6.1 (Build 20G224)

new install

1.36.66, default (shown)
  1. install 1.36.66
  2. launch Brave
  3. click on Skip welcome tour
  4. look at the widget stack on the right
  5. click on Brave Talk

Confirmed Brave Rewards and Brave Talk were shown by default
Confirmed Brave Rewards is focused by default
Confirmed widget and links work (checked in more detail at the end)

step 5 step 6
Screen Shot 2022-01-25 at 3 27 43 PM Screen Shot 2022-01-25 at 3 30 33 PM

migration

1.34.81, default
  1. install 1.34.81
  2. launch Brave
  3. click Skip welcome tour
  4. note the absence of a Brave Talk card on the new-tab page
  5. upgrade to 1.36.66 (rename Brave Browser profile on macOS to Brave Browser Nightly, and relaunch with 1.36.66)
  6. confirm theBrave Talk card is visible on the new-tab page (behind Brave Rewards)
  7. click on Brave Talk

Confirmed Brave Rewards and Brave Talk were shown by default
Confirmed Brave Rewards is focused by default
Confirmed widget and links work (checked in more detail at the end)

step 4 step 6 step 7
Screen Shot 2022-01-25 at 3 32 11 PM Screen Shot 2022-01-25 at 3 32 52 PM Screen Shot 2022-01-25 at 3 32 57 PM
1.34.81 ==> 1.36.66, card enabled
  1. install 1.34.81
  2. launch Brave
  3. click Skip welcome tour
  4. note the absence of a Brave Talk card on the new-tab page
  5. click Edit Cards
  6. click on + Add to add Brave Talk
  7. confirm it's added and visible
  8. upgrade to 1.36.66
  9. launch Brave
  10. confirm the Brave Talk card is on the new-tab page
step 4 step 7 step 10
Screen Shot 2022-01-25 at 3 20 10 PM Screen Shot 2022-01-25 at 3 20 31 PM Screen Shot 2022-01-25 at 3 21 19 PM

Confirmed Brave Rewards and Brave Talk were shown by default
Confirmed Brave Rewards is focused by default
Confirmed widget and links work (checked in more detail at the end)

1.34.81 ==> 1.36.66, card disabled
  1. install 1.34.81
  2. launch Brave
  3. click Skip welcome tour
  4. note the absence of a Brave Talk card on the new-tab page
  5. click Edit Cards
  6. click on + Add to add Brave Talk
  7. confirm it's added and visible
  8. click on the ... menu
  9. choose Hide Brave Talk
  10. confirm it's no longer visible
  11. shut down Brave
  12. upgrade to 1.36.66
  13. launch Brave
  14. confirm the Brave Talk card is NOT on the new-tab page
step 4 step 7 step 9 step 10 step 14
Screen Shot 2022-01-25 at 3 54 22 PM Screen Shot 2022-01-25 at 3 54 33 PM Screen Shot 2022-01-25 at 3 54 40 PM Screen Shot 2022-01-25 at 3 54 45 PM Screen Shot 2022-01-25 at 3 56 02 PM

Confirmed Brave Rewards and Brave Talk were shown by default
Confirmed Brave Rewards is focused by default
Confirmed widget and links work (checked in more detail at the end)

Confirmed (shared card):

  • Start call goes to https://talk.brave.com/widget
  • About your data goes to https://brave.com/privacy/browser/#brave-talk-learn
  • ... Hide - confirmed widget can be hidden/re-added

Verified PASSED using

Brave 1.36.83 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}

new install

1.36.83, default (shown)
  1. install 1.36.83
  2. launch Brave
  3. click on Skip welcome tour
  4. look at the widget stack on the right
  5. click on Brave Talk

Confirmed Brave Rewards and Brave Talk were shown by default
Confirmed Brave Rewards is focused by default
Confirmed widget and links work (checked in more detail at the end)

step 5 step 6
20015-1 20015-2

migration

1.35.100, default
  1. install 1.35.100
  2. launch Brave
  3. click Skip welcome tour
  4. note the absence of a Brave Talk card on the new-tab page
  5. upgrade to 1.36.84
  6. confirm theBrave Talk card is visible on the new-tab page (behind Brave Rewards)
  7. click on Brave Talk

Confirmed Brave Rewards and Brave Talk were shown by default
Confirmed Brave Rewards is focused by default
Confirmed widget and links work (checked in more detail at the end)

step 4 step 6 step 7
20015-3 20015-4 20015-5

Verified PASSED using

Brave 1.36.86 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Linux

new install

1.36.86, default (shown)
  1. install 1.36.83
  2. launch Brave
  3. click on Skip welcome tour
  4. look at the widget stack on the right
  5. click on Brave Talk

Confirmed Brave Rewards and Brave Talk were shown by default
Confirmed Brave Rewards is focused by default
Confirmed widget and links work (checked in more detail at the end)

step 5 step 6
Screen Shot 2022-02-07 at 1 32 48 PM Screen Shot 2022-02-07 at 1 33 06 PM

migration

1.34.81, default
  1. install 1.34.81
  2. launch Brave
  3. click Skip welcome tour
  4. note the absence of a Brave Talk card on the new-tab page
  5. upgrade to 1.36.86
  6. confirm the Brave Talk card is visible on the new-tab page (behind Brave Rewards)
  7. click on Brave Talk

Confirmed Brave Rewards and Brave Talk were shown by default
Confirmed Brave Rewards is focused by default
Confirmed widget and links work (checked in more detail at the end)

step 4 step 6 step 7
Screen Shot 2022-02-07 at 1 23 53 PM Screen Shot 2022-02-07 at 1 29 34 PM Screen Shot 2022-02-07 at 1 29 39 PM

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebron rebron

@simonhong simonhong

Labels
feature/new-tab needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Make brave talk widget visible by default brave/brave-core
4 participants
@mattmcalister @stephendonner @rebron @simonhong