Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token list jumps back to top when a token is added #19352

Closed
srirambv opened this issue Nov 10, 2021 · 2 comments · Fixed by brave/brave-core#11875
Closed

Token list jumps back to top when a token is added #19352

srirambv opened this issue Nov 10, 2021 · 2 comments · Fixed by brave/brave-core#11875
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include usability

Comments

@srirambv
Copy link
Contributor

Description

Token list jumps back to top when a token is added making it hard to add multiple items at a time

Steps to Reproduce

  1. Select Add token
  2. Scroll down a bit and select a token
  3. Jumps back to top doesn't retain the position

Actual result:

Jumplist.mov

Expected result:

Just add the token don't refresh until user clicks Done or closes the add token modal

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.95 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett @Douglashdaniel

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks usability QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 10, 2021
@Douglashdaniel
Copy link

This will be fixed when we implement this #18532

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 10, 2021
@Douglashdaniel Douglashdaniel self-assigned this Jan 11, 2022
@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 19, 2022
@srirambv
Copy link
Contributor Author

Brave 1.36.90 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description and brave/brave-core#11875
  • Verified selecting a token via checkbox doesn't cause the list to jump back to the top
19352-Linux.mp4
19352-Windows.mov
19352-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include usability
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants