Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing multiple Visible Assets Information to BraveWalletService calls #18532

Closed
Douglashdaniel opened this issue Oct 4, 2021 · 3 comments
Closed

Allow passing multiple Visible Assets Information to BraveWalletService calls #18532

Douglashdaniel opened this issue Oct 4, 2021 · 3 comments
Labels
closed/duplicate Issue has already been reported feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop perf priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@Douglashdaniel
Copy link

Description

Consider Refactoring the the BraveWalletService: addUserAsset, removeUserAsset and setUserAssetVisible api's to allow multiple assets to be passed in, in one call. See discussion here: brave/brave-core#10336 (comment)
@Douglashdaniel Douglashdaniel mentioned this issue Oct 4, 2021
Merged
24 tasks
@bbondy bbondy added the perf label Oct 7, 2021
@yrliou yrliou assigned yrliou and unassigned yrliou Oct 13, 2021
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Oct 29, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 10, 2021
Closed
@bbondy bbondy self-assigned this Dec 21, 2021
@bbondy
Copy link
Member

bbondy commented Jan 7, 2022

unassigned for now because I think we can fix this front end side without native changes. If that changes please let me know.

@bbondy
Copy link
Member

bbondy commented Jan 7, 2022

We can also close this please from the front end team once it is confirmed if it can be done from the front end side.

@bbondy bbondy removed their assignment Jan 7, 2022
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 7, 2022
@Douglashdaniel Douglashdaniel added the closed/duplicate Issue has already been reported label Jan 19, 2022
@Douglashdaniel
Copy link
Author

Was able to implement these changes on the front-end side in this PR brave/brave-core#11875
Closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop perf priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @yrliou @Douglashdaniel