Disabling WDP via Tor disables WDP in Normal windows

[kjozwiak]

Description

When you have WDP enabled via brave://settings/search in Normal windows, launching Tor will disable the setting. This is a follow up to #18885.

Steps to Reproduce

1. launch Brave via a clean profile
2. enable WDP via brave://search/settings and ensure that WDP.IsRunning --> true
3. launch a Tor window
4. you'll notice that WDP has been disabled via brave://settings/search
5. close the Tor window and the WDP setting will still be disabled

Actual result:

The WDP setting is being reset to disabled via Normal windows when a Tor window is a launched

Expected result:

WDP should be disabled for Tor windows but it shouldn't affect the state of Normal windows.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.33.30 Chromium: 95.0.4638.54 (Official Build) nightly (64-bit)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | Windows 11 Version 21H2 (Build 22000.258)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A (Disable Web Discovery Project in Tor windows brave-core#10609 only in master)
• Can you reproduce this issue with the beta channel? N/A (Disable Web Discovery Project in Tor windows brave-core#10609 only in master)
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @remusao @rebron @diracdeltas

[remusao]

Resolved by brave/brave-core#10670

[kjozwiak]

STR/Cases can be used from brave/brave-core#10670 (comment).

[stephendonner]

Verified PASSED using

Brave	1.31.88 Chromium: 95.0.4638.69 (Official Build) (x86_64)
Revision	6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS	macOS Version 11.6.1 (Build 20G224)

Steps:

1. launched Brave via a clean profile
2. enabled WDP via brave://search/settings and ensure that WDP.IsRunning --> true via brave://inspect#extensions -> console
3. launched a Private Window with Tor
4. closed the Tor window

Confirmed once set, the Web Discovery Project toggle remained On

example	example	example

See also additional, thorough verification in #18885 (comment).

---

Verification passed on

Brave | 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
-- | --
Revision | 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS | Windows 10 Version 21H1 (Build 19043.1288)

Steps:

1. launched Brave via a clean profile
2. enabled WDP via brave://settings/search and ensure that WDP.isRunning --> true via brave://inspect#extensions -> console
3. launched a Private Window with Tor
4. closed the Tor window

Confirmed once set, the Web Discovery Project toggle remained On

example	example	example

---

Verification passed on

Brave	1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
Revision	d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS	Ubuntu 18.04 LTS