Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure WDP is completely disabled on Tor windows #18885

Closed
remusao opened this issue Oct 20, 2021 · 2 comments · Fixed by brave/brave-core#10609 or brave/brave-core#10670
Closed

Make sure WDP is completely disabled on Tor windows #18885

remusao opened this issue Oct 20, 2021 · 2 comments · Fixed by brave/brave-core#10609 or brave/brave-core#10670

Comments

@remusao
Copy link

remusao commented Oct 20, 2021

Description

Currently, when a user opts-in, the Web Discovery Project will also be initialized in Tor windows. This is unintended and we should add a check similar to https://github.com/brave/brave-core/blob/master/browser/tor/tor_profile_manager.cc#L130 for WDP.

Steps to Reproduce

  1. Opt-into WDP in Brave browser.
  2. Open a Tor Window
  3. Visit brave://inspect tab extensions
  4. WDP is initialized (can be seen in console when clicking on inspect

Actual result:

WDP is initialized.

Expected result:

WDP should not be initialized.

Reproduces how often:

Brave version (brave://version info)

Current stable release: Version 1.31.87 Chromium: 95.0.4638.54 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? no
  • Is the issue reproducible on the latest version of Chrome? no

Miscellaneous Information:

@kjozwiak
Copy link
Member

STR/Cases can be used from brave/brave-core#10670 (comment).

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 29, 2021
@stephendonner
Copy link

stephendonner commented Oct 29, 2021

Verified PASSED using

Brave 1.31.88 Chromium: 95.0.4638.69 (Official Build) (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)

Used brave://inspect/#extensions to check WDP.isRunning

  • ensured that WDP via brave://settings/search is disabled by default on new profiles
  • ensured that WDP.isRunning returns false when WDP is disabled in Normal mode
  • ensured that WDP.isRunning returns true when WDP is enabled in Normal mode
  • ensured that WDP.isRunning returns undefined via both Tor/Private/Guest when WDP is disabled in Normal mode
  • ensured that WDP.isRunning returns undefined via both Tor/Private/Guest windows if already enabled via Normal mode
  • ensured that launching a Tor/Private/Guest window doesn't enable or disable WDP via Normal mode
Normal (default) Normal (enabled) Tor (default) Tor (enabled) Private (default) Private (enabled) Guest (default) Guest (enabled)
Screen Shot 2021-10-29 at 4 14 56 AM Screen Shot 2021-10-29 at 4 14 41 AM Screen Shot 2021-10-29 at 4 16 24 AM Screen Shot 2021-10-29 at 4 16 08 AM Screen Shot 2021-10-29 at 4 16 24 AM Screen Shot 2021-10-29 at 4 16 08 AM Screen Shot 2021-10-29 at 4 17 05 AM Screen Shot 2021-10-29 at 4 17 24 AM

Verification passed on


Brave | 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
-- | --
Revision | 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS | Windows 10 Version 21H1 (Build 19043.1288)

Used brave://inspect/#extensions to check WDP.isRunning

  • ensured that WDP via brave://settings/search is disabled by default on new profiles
  • ensured that WDP.isRunning returns false when WDP is disabled in Normal mode
  • ensured that WDP.isRunning returns true when WDP is enabled in Normal mode
  • ensured that WDP.isRunning returns undefined via both Tor/Private/Guest when WDP is disabled in Normal mode
  • ensured that WDP.isRunning returns undefined via both Tor/Private/Guest windows if already enabled via Normal mode
  • ensured that launching a Tor/Private/Guest window doesn't enable or disable WDP via Normal mode
Normal (default) Normal (enabled) Tor (default) Tor (enabled) Private (default) Private (enabled) Guest (default) Guest (enabled)
image image image image image image image image

Verification passed on

Brave 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Ubuntu 18.04 LTS

Used brave://inspect/#extensions to check WDP.isRunning

  • ensured that WDP via brave://settings/search is disabled by default on new profiles
  • ensured that WDP.isRunning returns false when WDP is disabled in Normal mode
  • ensured that WDP.isRunning returns true when WDP is enabled in Normal mode
  • ensured that WDP.isRunning returns undefined via both Tor/Private/Guest when WDP is disabled in Normal mode
  • ensured that WDP.isRunning returns undefined via both Tor/Private/Guest windows if already enabled via Normal mode
  • ensured that launching a Tor/Private/Guest window doesn't enable or disable WDP via Normal mode
Normal (default) Normal (enabled) Tor (default) Tor (enabled) Private (default) Private (enabled) Guest (default) Guest (enabled)
image image image image image image image image

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment