Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hackerone] #1376663 - Null deref in BRAVE_ICON_LABEL_BUBBLE_VIEW_GET_HIGHLIGHT_PATH #18918

Closed
jumde opened this issue Oct 21, 2021 · 4 comments · Fixed by brave/brave-core#10647

Comments

@jumde
Copy link
Contributor

jumde commented Oct 21, 2021

https://hackerone.com/bugs?report_id=1376663

@stephendonner
Copy link

Verified PASSED using

Brave 1.33.32 Chromium: 95.0.4638.54 (Official Build) nightly (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. Enabled media router in brave://settings/extensions
  2. Enabled all cast flags in brave://flags
  3. Navigated to https://jumde.github.io/test/cast.html and clicked cast
  4. Should not crash

Confirmed I didn't crash, and got the little test media popup.

example example example example
Screen Shot 2021-10-25 at 11 46 10 AM Screen Shot 2021-10-25 at 11 47 15 AM Screen Shot 2021-10-25 at 11 48 04 AM Screen Shot 2021-10-25 at 11 48 16 AM

@stephendonner
Copy link

@jumde are we sure this is applicable to Android? I find no cast or media-related settings in brave://flags. (Read through https://support.google.com/chromecast/answer/3228332?co=GENIE.Platform%3DAndroid&oco=1 too.) Thanks!

@stephendonner stephendonner removed the OS/Android Fixes related to Android browser functionality label Nov 10, 2021
@stephendonner
Copy link

Removed OS/Android per convo with @srirambv

@stephendonner
Copy link

stephendonner commented Nov 15, 2021

Verified PASSED using

Brave 1.33.79 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1288)

Steps:

  1. enabled Media Router via brave://settings/extensions
  2. enable all cast feature flags via brave://flags
  3. navigated to https://jumde.github.io/test/cast.html and clicked cast
  4. should not crash

Confirmed I didn't crash, and the little test media popup displayed.

example example example
enable-media-router all-cast-settings cast-popup

Verified PASSED using

Brave 1.33.85 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Steps:

  1. Enabled media router in brave://settings/extensions
  2. Enabled all cast flags in brave://flags
  3. Navigated to https://jumde.github.io/test/cast.html and clicked cast
  4. Should not crash

Confirmed I didn't crash, and the little test media popup displayed.

example example example
Screen Shot 2021-11-19 at 5 52 39 PM Screen Shot 2021-11-19 at 5 53 40 PM Screen Shot 2021-11-19 at 5 54 08 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment