Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18918 - Null deref in BRAVE_ICON_LABEL_BUBBLE_VIEW_GET_HIGHLIGHT_PATH #10647

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 21, 2021

Resolves brave/brave-browser#18918

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable media router in brave://settings/extensions
  2. Enable all cast flags in brave://cast
  3. Navigate to https://jumde.github.io/test/cast.html and click cast
  4. Should not crash

@jumde jumde requested a review from a team as a code owner October 21, 2021 19:14
@jumde jumde force-pushed the null_deref_icon_bubble_view branch 2 times, most recently from 9a7201d to ec41087 Compare October 21, 2021 19:42
@jumde jumde requested review from petemill and nullhook October 21, 2021 19:43
@jumde jumde force-pushed the null_deref_icon_bubble_view branch 2 times, most recently from 16d3bac to 059f447 Compare October 21, 2021 20:10
@jumde jumde requested a review from mkarolin October 21, 2021 20:11
@petemill
Copy link
Member

petemill commented Oct 21, 2021

Out of interest are you aware of which icon label bubble view is being made in this scenario where there is no layoutprovider? I presume it's related to casting and it gets created when

request = new PresentationRequest([location]);
   request.start().then(
   connection=>{
   console.log(2);
   }

is run

edit: I guess it's this
image

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src++

@jumde
Copy link
Contributor Author

jumde commented Oct 21, 2021

Out of interest are you aware of which icon label bubble view is being made in this scenario where there is no layoutprovider? I presume it's related to casting and it gets created when

request = new PresentationRequest([location]);
   request.start().then(
   connection=>{
   console.log(2);
   }

is run

edit: I guess it's this image

right

@jumde jumde force-pushed the null_deref_icon_bubble_view branch from 059f447 to ab9d144 Compare October 22, 2021 15:57
Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jumde jumde merged commit c711ea2 into master Oct 22, 2021
@jumde jumde deleted the null_deref_icon_bubble_view branch October 22, 2021 20:05
@jumde jumde added this to the 1.33.x - Nightly milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hackerone] #1376663 - Null deref in BRAVE_ICON_LABEL_BUBBLE_VIEW_GET_HIGHLIGHT_PATH
4 participants