Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin test page for TLS pinning #18352

Closed
fmarier opened this issue Sep 24, 2021 · 1 comment · Fixed by brave/brave-core#10253
Closed

Pin test page for TLS pinning #18352

fmarier opened this issue Sep 24, 2021 · 1 comment · Fixed by brave/brave-core#10253

Comments

@fmarier
Copy link
Member

fmarier commented Sep 24, 2021

Now that we have a test page which is using a CA outside of our pinset (Sectigo), we need to pin it in order to trigger the interstitial page.

@stephendonner
Copy link

stephendonner commented Sep 29, 2021

Verified PASSED using

Brave 1.32.31 Chromium: 94.0.4606.61 (Official Build) nightly (x86_64)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. clean profile
  2. launched Brave
  3. loaded https://ssl-pinning.someblog.org/

Confirmed I now see the interstitial warning page

before after
Screen Shot 2021-09-29 at 8 32 01 AM Screen Shot 2021-09-29 at 8 32 08 AM

Verification passed on


Brave | 1.32.78 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | Windows 10 Version 21H1 (Build 19043.1288)

Confirmed I now see the interstitial warning page after navigating to https://ssl-pinning.someblog.org/

before after
image image

Verified PASSED using

Brave 1.32.78 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Linux

Steps:

  1. new profile
  2. launch Brave
  3. loaded https://ssl-pinning.someblog.org in both current release and 1.32.x
before after
Screen Shot 2021-10-25 at 12 51 58 PM Screen Shot 2021-10-25 at 12 50 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment