Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use most recent text from copywriter for WDP in settings #18316

Closed
kkuehlz opened this issue Sep 23, 2021 · 1 comment · Fixed by brave/brave-core#10229
Closed

Use most recent text from copywriter for WDP in settings #18316

kkuehlz opened this issue Sep 23, 2021 · 1 comment · Fixed by brave/brave-core#10229
Labels
Brave Search feature/search OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.31.x - Release

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Sep 23, 2021 •
edited
Loading

Text body needs to be changed to: Contribute some anonymous search & browsing data to refine Brave Search. Learn more

Learn more URL should be changed from help center to https://brave.com/browser/privacy/#web-discovery-project
@kkuehlz kkuehlz mentioned this issue Sep 23, 2021
Merged
24 tasks
kkuehlz pushed a commit to brave/brave-core that referenced this issue Sep 23, 2021
Update WDP settings with most recent text and url
5adbf60 
Resolves brave/brave-browser#18316
kkuehlz pushed a commit to brave/brave-core that referenced this issue Sep 24, 2021
Update WDP settings with most recent text and url
a5b817e 
Resolves brave/brave-browser#18316
@kkuehlz kkuehlz added this to the 1.32.x - Nightly milestone Sep 24, 2021
@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Sep 27, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.31.62 Chromium: 94.0.4606.54 (Official Build) beta (x86_64)
Revision c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launch Brave
  3. load brave://settings/search
  4. read the description for Web Discovery Project
  5. clicked on Learn more link

Confirmed:

  • description changed to Contribute some anonymous search & browsing data to refine Brave Search.
  • Learn more link goes to https://brave.com/browser/privacy/#web-discovery-project
example example
Screen Shot 2021-09-27 at 2 46 55 PM Screen Shot 2021-09-27 at 2 49 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Brave Search feature/search OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Update WDP settings with most recent text brave/brave-core
3 participants
@stephendonner @kjozwiak @kkuehlz