Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash reporting should be enabled by default on nightly #18315

Closed
stephendonner opened this issue Sep 23, 2021 · 9 comments · Fixed by brave/brave-core#10266
Closed

Crash reporting should be enabled by default on nightly #18315

stephendonner opened this issue Sep 23, 2021 · 9 comments · Fixed by brave/brave-core#10266
Assignees
@simonhong
Labels
bug OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.32.x - Release

Comments

@stephendonner
Copy link

Description

Crash reporting should be enabled by default on nightly

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://settings/privacy
  4. look at the default for Help improve Brave's features and performance

Actual result:

It's toggled to off by default

Screen Shot 2021-09-23 at 9 11 08 AM

Expected result:

Should be toggled to on by default

Screen Shot 2021-09-23 at 9 17 07 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.32.17 Chromium: 94.0.4606.54 (Official Build) nightly (x86_64)
Revision c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS macOS Version 11.6 (Build 20G165)

/cc @rebron @simonhong @karenkliu
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 23, 2021
@simonhong
Copy link
Member

@stephendonner Can you check this also on Windows?
I can repro this on macOS also but can't on Windows.

@simonhong simonhong self-assigned this Sep 24, 2021
@stephendonner
Copy link
Author

@stephendonner Can you check this also on Windows?
I can repro this on macOS also but can't on Windows.

Sorry for the delay; can confirm it's on by default in the latest nightly on Windows 10.

@simonhong
Copy link
Member

@stephendonner Thanks for checking :)

@simonhong
Copy link
Member

Only macOS has this issue. linux is also fine.

@simonhong simonhong mentioned this issue Sep 27, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Sep 27, 2021
@simonhong
Fixed crash reporing is disabled by default on macOS for nightly/beta…
30e5c9b 
… channel

fix brave/brave-browser#18315

When first-run dialog is closed, crash reporting pref is set based
on FirstRunDialogViewController::isStatsReportingEnabled.
So far, it returns always false.
It should return the value of GetDefaultPrefValueForMetricsReporting().
@simonhong simonhong added this to the 1.32.x - Nightly milestone Sep 27, 2021
@stephendonner
Copy link
Author

stephendonner commented Sep 27, 2021 •
edited by LaurenWags
Loading

Verified PASSED using

Brave 1.32.26 Chromium: 94.0.4606.61 (Official Build) nightly (x86_64)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launch Brave
  3. load brave://settings/privacy
  4. look at the default for Help improve Brave's features and performance
  5. confirmed it's checked
  6. loaded brave://inducebrowsercrashforrealz
  7. crashed
  8. confirmed I didn't see a crash-submission prompt
  9. confirmed I was prompted to restore pages upon restart
  10. confirmed brave://crashes shows my auto-submitted crash incident
example example example
Screen Shot 2021-09-27 at 10 59 54 AM Screen Shot 2021-09-27 at 11 01 06 AM Screen Shot 2021-09-27 at 11 01 14 AM

Verified passed on Beta channel using

Brave | 1.32.78 Chromium: 95.0.4638.54 (Official Build) beta (x86_64)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launch Brave
  3. load brave://settings/privacy
  4. look at the default for Help improve Brave's features and performance
  5. confirmed it's checked
  6. loaded brave://inducebrowsercrashforrealz
  7. crashed
  8. confirmed I didn't see a crash-submission prompt
  9. confirmed I was prompted to restore pages upon restart
  10. confirmed brave://crashes shows my auto-submitted crash incident

Note - did steps 6-9 2x since I forgot to take a screenshot, that's why there are 2 crashes shown in below

example example example
Screen Shot 2021-10-25 at 10 26 48 AM Screen Shot 2021-10-25 at 10 27 36 AM Screen Shot 2021-10-25 at 10 28 09 AM

Verified passed on Dev channel using

Brave	1.32.77 Chromium: 95.0.4638.54 (Official Build) dev (x86_64)
Revision	d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS	macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launch Brave
  3. load brave://settings/privacy
  4. look at the default for Help improve Brave's features and performance
  5. confirmed it's checked
  6. loaded brave://inducebrowsercrashforrealz
  7. crashed
  8. confirmed I didn't see a crash-submission prompt
  9. confirmed I was prompted to restore pages upon restart
  10. confirmed brave://crashes shows my auto-submitted crash incident
example example example
Screen Shot 2021-10-25 at 10 36 33 AM Screen Shot 2021-10-25 at 10 37 03 AM Screen Shot 2021-10-25 at 10 37 16 AM

@LaurenWags
Copy link
Member

Removing QA Pass-macOS and adding QA/Blocked as we will need to confirm on an RC that crash reporting is not enabled by default on Release channel.

@LaurenWags
Copy link
Member

Removing QA/Blocked as we have a 1.32.x RC which can be used to verify this

@LaurenWags
Copy link
Member

Verified on Release channel:

Brave | 1.32.97 Chromium: 96.0.4664.35 (Official Build) (x86_64)
-- | --
Revision | 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS | macOS Version 11.6.1 (Build 20G224)

Confirmed crash reporting is not enabled by default on release channel.

Steps:

  1. new profile 1.32.97
  2. launch Brave
  3. load brave://settings/privacy
  4. look at the default for Help improve Brave's features and performance
  5. confirmed it is not enabled
  6. loaded brave://inducebrowsercrashforrealz
  7. crashed
  8. on relaunch, confirmed I did see a crash-submission prompt
  9. confirmed I was prompted to restore pages
  10. confirmed clicking "Block" did not enable crash reporting
  11. confirmed brave://crashes shows my crash report as not submitted
  12. loaded brave://inducebrowsercrashforrealz again
  13. crashed
  14. on relaunch, confirmed I saw crash submission prompt again
  15. selected "Don't ask again" and Block
  16. confirmed I was prompted to restore pages
  17. confirmed clicking "Block" did not enable crash reporting
  18. confirmed brave://crashes shows my crash report as not submitted
  19. loaded brave://inducebrowsercrashforrealz again
  20. crashed
  21. on relaunch, confirmed I did not see crash submission prompt
  22. confirmed I was prompted to restore pages
Example Example Example
Screen Shot 2021-11-10 at 10 29 54 AM Screen Shot 2021-11-10 at 10 30 19 AM Screen Shot 2021-11-10 at 10 30 56 AM
  1. new profile 1.32.97
  2. launch Brave
  3. load brave://settings/privacy
  4. look at the default for Help improve Brave's features and performance
  5. confirmed it is not enabled
  6. loaded brave://inducebrowsercrashforrealz
  7. crashed
  8. on relaunch, confirmed I did see a crash-submission prompt
  9. clicked "Allow"
  10. confirmed I was prompted to restore pages
  11. confirmed clicking "Allow" did enable crash reporting
  12. loaded brave://inducebrowsercrashforrealz again
  13. crashed
  14. on relaunch, confirmed I did not see crash submission prompt
  15. confirmed I was prompted to restore pages
  16. confirmed my crash report was shown as submitted
Example Example Example Example
Screen Shot 2021-11-10 at 10 42 30 AM Screen Shot 2021-11-10 at 10 42 52 AM Screen Shot 2021-11-10 at 10 43 12 AM Screen Shot 2021-11-10 at 10 46 21 AM

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.33.72 Chromium: 96.0.4664.35 (Official Build) nightly (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS macOS Version 11.6.1 (Build 20G224)

Confirmed crash reporting is not enabled by default on release channel.

Steps:

  1. new profile 1.32.97
  2. launch Brave
  3. load brave://settings/privacy
  4. look at the default for Help improve Brave's features and performance
  5. confirmed it is not enabled
  6. loaded brave://inducebrowsercrashforrealz
  7. crashed
  8. on relaunch, confirmed I did see a crash-submission prompt
  9. confirmed I was prompted to restore pages
  10. confirmed clicking "Block" did not enable crash reporting
  11. confirmed brave://crashes shows my crash report as not submitted
  12. loaded brave://inducebrowsercrashforrealz again
  13. crashed
  14. on relaunch, confirmed I saw crash submission prompt again
  15. selected "Don't ask again" and Block
  16. confirmed I was prompted to restore pages
  17. confirmed clicking "Block" did not enable crash reporting
  18. confirmed brave://crashes shows my crash report as not submitted
  19. loaded brave://inducebrowsercrashforrealz again
  20. crashed
  21. on relaunch, confirmed I did not see crash submission prompt
  22. confirmed I was prompted to restore pages
example example example
Screen Shot 2021-11-10 at 8 47 51 AM Screen Shot 2021-11-10 at 8 48 41 AM Screen Shot 2021-11-10 at 8 49 11 AM
  1. new profile 1.32.97
  2. launch Brave
  3. load brave://settings/privacy
  4. look at the default for Help improve Brave's features and performance
  5. confirmed it is not enabled
  6. loaded brave://inducebrowsercrashforrealz
  7. crashed
  8. on relaunch, confirmed I did see a crash-submission prompt
  9. clicked "Allow"
  10. confirmed I was prompted to restore pages
  11. confirmed clicking "Allow" did enable crash reporting
  12. loaded brave://inducebrowsercrashforrealz again
  13. crashed
  14. on relaunch, confirmed I did not see crash submission prompt
  15. confirmed I was prompted to restore pages
  16. confirmed my crash report was shown as submitted
example example example example
Screen Shot 2021-11-10 at 8 55 09 AM Screen Shot 2021-11-10 at 8 55 32 AM Screen Shot 2021-11-10 at 8 56 03 AM Screen Shot 2021-11-10 at 8 57 07 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed crash reporting is disabled by default on macOS for nightly/beta brave/brave-core
4 participants
@stephendonner @rebron @simonhong @LaurenWags