Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta disk-image icon background should be transparent #18223

Closed
stephendonner opened this issue Sep 20, 2021 · 2 comments · Fixed by brave/brave-core#10283
Closed

Beta disk-image icon background should be transparent #18223

stephendonner opened this issue Sep 20, 2021 · 2 comments · Fixed by brave/brave-core#10283

Comments

@stephendonner
Copy link

Description

Beta disk-image icon background should be transparent

Found while testing #17441

Steps to Reproduce

  1. download 1.31.54 from https://github.com/brave/brave-browser/releases/tag/v1.31.54
  2. double-click to uncompress the file
  3. look at the disk-image icon

Actual result:

Screen Shot 2021-09-20 at 11 17 42 AM

Expected result:

No white background; it should be transparent

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.31.54 Chromium: 94.0.4606.50 (Official Build) beta (x86_64)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS macOS Version 11.6 (Build 20G165)

/cc @simonhong

@karenkliu
Copy link

Hi, sorry I found a white background included in the icon export - it's fixed now. @simonhong

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.32.69 Chromium: 95.0.4638.40 (Official Build) beta (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)
example example example example example
Screen Shot 2021-10-14 at 11 13 04 AM Screen Shot 2021-10-14 at 11 13 08 AM Screen Shot 2021-10-14 at 11 13 39 AM Screen Shot 2021-10-14 at 11 13 57 AM Screen Shot 2021-10-14 at 11 14 05 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment