Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to start the video call via Try it now promo prompt #17421

Closed
GeetaSarvadnya opened this issue Aug 10, 2021 · 7 comments
Closed

Unable to start the video call via Try it now promo prompt #17421

GeetaSarvadnya opened this issue Aug 10, 2021 · 7 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 10, 2021

Description

Unable to start the video call via Try it now promo tooltip

Steps to Reproduce

  1. Clean profile 1.28.x/1.29.x/130.x
  2. Confirm Brave Talk study is enabled in brave://version
  3. Forward the OS clock to 3 days
  4. Open a new tab page/existing new tab page
  5. Observe the Try it now promo tooltip in NTP
  6. Click on Try it now
  7. Click on Start a video call doesn't initiate the video call, throwing the error message as Request failed: internal error

(launched brave using brave.exe --variations-server-url=https://variations.bravesoftware.com/seed in 1.28.105)

Actual result:

Click on Start a video call doesn't initiate the video call, throwing the error message as Request failed: internal error
image

Expected result:

Should not get any error and should be able to start the video call

Reproduces how often:

Easy

Brave version (brave://version info)

RC: 1.28.105
Beta: 1.29.55
Nightly: 1.30.9

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @petemill @mrose17

@mrose17
Copy link
Member

mrose17 commented Aug 10, 2021

What is the reason for 3. Forward the OS clock to 3 days?

Also, are we talking about this tooltip (in Brave Nightly)?
Screen Shot 2021-08-10 at 09 23 32

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Aug 10, 2021

@mrose17: As per the test plan brave/brave-core#9616 Brave Talk promo tooltip should be shown to the new users only after forwarding OS date to 3 days ahead. We are talking about the Try it now prompt, sorry for the confusion.
image

@GeetaSarvadnya GeetaSarvadnya changed the title Unable to start the video call via Try it now promo tooltip Unable to start the video call via Try it now promo prompt Aug 10, 2021
@mrose17
Copy link
Member

mrose17 commented Aug 10, 2021

Fascinating. I am not surprised that messing with the clock causes problems with cryptographic operations. perhaps there is a better way to test this?

@GeetaSarvadnya
Copy link
Author

I am not aware of the other ways to test this in a clean profile. @petemill - Any thoughts on this?

@mrose17
Copy link
Member

mrose17 commented Aug 10, 2021

Here are two possibilities:

First,

  1. Set the clock back 3 days and then create a new profile.
  2. Quit the browser.
  3. Set the clock to the current time and start the browser.

Second, create a new profile at the current time. Periodically check to see if the tooltip comes up within the first three days. (Obviously, this is something that will take at least three days to test...)

@GeetaSarvadnya
Copy link
Author

@mrose17 we just followed the steps mentioned in the slack thread mentioned below, it worked fine we're waiting for confirmation from @petemill
https://bravesoftware.slack.com/archives/C7VLGSR55/p1628602926082900?thread_ts=1628596170.077200&cid=C7VLGSR55

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Aug 10, 2021

Works as expected. closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants