Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Try it out" should link to talk.brave.com/widget on promo tooltip #17147

Closed
stephendonner opened this issue Jul 24, 2021 · 5 comments · Fixed by brave/brave-core#9581
Closed

Comments

@stephendonner
Copy link

Description

"Try it out" should link to talk.brave.com/widget on promo tooltip

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. open a new-tab page
  4. on the bottom right, click on the Try it out button
  5. see where it links to

Actual result:

Goes to https://together.brave.com/widget.

Screen Shot 2021-07-24 at 12 19 52 PM

Expected result:

Should go to https://talk.brave.com/widget.

Reproduces how often:

100%

Brave version (info found on brave://version)

Brave 1.29.20 Chromium: 92.0.4515.107 (Official Build) nightly (x86_64)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS macOS Version 12.0 (Build 21A5284e)
@stephendonner
Copy link
Author

@bsclifton mind getting an uplift going for 1.28.x? /cc @mattmcalister

@bsclifton
Copy link
Member

@stephendonner done - brave/brave-core#9608

@kjozwiak
Copy link
Member

kjozwiak commented Aug 9, 2021

Adding QA/Blocked until we get Brave Talk enabled on main (staging) via Griffin. After it's enabled on staging, QA will be able to run through the above verification. Once we get closer to Brave Talk release date, we'll push the same change into production.

@kjozwiak
Copy link
Member

kjozwiak commented Aug 9, 2021

Removing QA/Blocked as brave/brave-variations#93 was merged into main (Griffin staging).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 10, 2021

Verification passed on

Brave | 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1110)

image image
  • Confirmed that click on the Brave Talk tooltip icon in the bottom right corner of NTP redirects to https://talk.brave.com/widget
  • Confirmed that click on Start video call initiates the call successfully
image image image
  • Edit the cards and add Brave Talk to NTP widget and confirmed that Start video call redirects to https://talk.brave.com/widget
  • Confirmed that click on Start video call initiates the call successfully
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment