Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #16828

Closed
spylogsster opened this issue Jul 8, 2021 · 1 comment · Fixed by brave/brave-core#9364
Closed

Fix typos #16828

spylogsster opened this issue Jul 8, 2021 · 1 comment · Fixed by brave/brave-core#9364
Assignees
@spylogsster
Labels
feature/web3/ipfs needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.28.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Jul 8, 2021 •
edited
Loading

Few nits

brave/brave-core#9342 (comment)
brave/brave-core#9342 (comment)
brave/brave-core#9258 (comment)

Test Plan

  • check that export menu item works
  • check keys are loaded after start
@spylogsster spylogsster self-assigned this Jul 8, 2021
@spylogsster spylogsster mentioned this issue Jul 8, 2021
Merged
24 tasks
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Jul 8, 2021
@spylogsster spylogsster added this to the 1.28.x - Nightly milestone Jul 8, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.28.74 Chromium: 92.0.4515.93 (Official Build) nightly (x86_64)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS macOS Version 11.4 (Build 20F71)

Confirmed importing and exporting/rotating keys still works.
Confirmed keys are available for signing published IPFS content.
Confirmed keys are loaded on start of Brave.

example example
Screen Shot 2021-07-12 at 2 45 32 PM Screen Shot 2021-07-12 at 2 45 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/ipfs needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging a pull request may close this issue.

Fix typos brave/brave-core
4 participants
@stephendonner @spylogsster @bsclifton @LaurenWags