Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added retries to keys loading #9342

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Added retries to keys loading #9342

merged 1 commit into from
Jul 6, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jul 6, 2021

Resolves brave/brave-browser#16743

  • Added retries to keys loading

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth and click Use a local node
  4. go to brave://settings/ipfs/keys and click on the reload icon next to the self key
  5. type rotatedKey and click Rotate

@spylogsster spylogsster requested a review from bbondy July 6, 2021 13:59
@spylogsster spylogsster self-assigned this Jul 6, 2021
@spylogsster spylogsster force-pushed the rotation-mac branch 2 times, most recently from f450b87 to c8f91ec Compare July 6, 2021 14:03
@spylogsster spylogsster merged commit 6e530ff into master Jul 6, 2021
@spylogsster spylogsster deleted the rotation-mac branch July 6, 2021 20:43
@spylogsster spylogsster added this to the 1.28.x - Nightly milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotated keys don't appear until you manually reload the Settings page
3 participants